Skip to content

Admin product search - Pressing enter does not submit #4696 #11827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2017
Merged

Admin product search - Pressing enter does not submit #4696 #11827

merged 1 commit into from
Oct 28, 2017

Conversation

bohemiorulo
Copy link

Admin product search - Pressing enter does not submit #4696

Description

Added ko keyboard observer for key intro

Fixed Issues (if relevant)

  1. Pressing enter should submit the form (good UX)

Manual testing scenarios

  1. Login to the admin
  2. Go to products > catalog
  3. Click on filters
  4. Enter some text in the name field
  5. Press enter on your keyboard

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@ishakhsuvarov ishakhsuvarov self-assigned this Oct 28, 2017
@ishakhsuvarov ishakhsuvarov added this to the October 2017 milestone Oct 28, 2017
@okorshenko okorshenko merged commit 29d175d into magento:2.2-develop Oct 28, 2017
okorshenko pushed a commit that referenced this pull request Oct 28, 2017
@ishakhsuvarov
MAGETWO-82954: Admin product search - Pressing enter does not submit #…
124dc45 
…4696 #11827
okorshenko pushed a commit that referenced this pull request Oct 28, 2017
@ishakhsuvarov
Merge pull request #1637 from magento-engcom/2.2-develop-prs
373bd01 
[EngCom] Public Pull Requests - 2.2-develop
 - MAGETWO-82954: Admin product search - Pressing enter does not submit #4696 #11827
 - MAGETWO-82953: Fix #11581: Reference to wrong / non-existing class #11830
 - MAGETWO-82887: X-Magento-Tags header containing whitespaces causes exception #11767
 - MAGETWO-82886: Improve error reporting for products images import. #11779
 - MAGETWO-82754: Magento setup:install interactive shell #11425
 - MAGETWO-81594: Issue #6924: Unmask exception message during product import #11363
@okorshenko
Copy link
Contributor

Hi @bohemiorulo please accept the invite on the GitHub to join magento team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ishakhsuvarov ishakhsuvarov

Labels
Progress: accept Release Line: 2.2
Projects
None yet
Milestone
October 2017
Development

Successfully merging this pull request may close these issues.
4 participants
@bohemiorulo @okorshenko @magento-team @ishakhsuvarov