8255: Export Products action doesn't consider hide_for_product_page value.

[nmalevanec]

Description

Fix Export and Import Products action doesn't consider hide_for_product_page value.

Fixed Issues (if relevant)

1. Export Products action doesn't consider hide_for_product_page value #8255: Export Products action doesn't consider hide_for_product_page value

Manual testing scenarios

1. Create a simple product and upload an image.
2. Change the scope to 1 store view.
3. Set the image as Hide for product page in that store view.
4. Navigate to System -> Export.
5. Select Products and then Continue.
6. Check that CSV files should have 2 lines. The default values at the first row of values.
7. The second lines should contain values on sku, store_view_code and hide_from_product_page columns.
8. Remove created simple product.
9. Navigate to System -> Import.
10. Import product from exported CSV with add/update behavior.
11. Check, imported product at 1 store view has "Hide fro product page" checked for image.

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[dmanners]

@nmalevanec could you have a look at the merge conflicts for me please.

[nmalevanec]

@dmanners Done.

[dmanners]

Does this also change the behavior for non-image multi-select data also? Do we have a test covering this?

[nmalevanec]

It covers by Magento/CatalogImportExport/Model/Export/ProductTest::testExport() for instance. Exported product has multiselect data.

[dmanners]

I know we already have a massive file here but would it make sense/be possible to extract the image processing to a separate class?

[nmalevanec]

Done.

[dmanners]

Is this format json? I would be a bit worried that we are calling unserialize/serialize on data that we do not trust/have control over.

[nmalevanec]

Removed.

[dmanners]

There are two test failures currently. Could you look into them please.

1) Magento\CatalogImportExport\Model\Export\ProductTest::testExportWithMedia
--
13-Nov-2017 04:15:27 | [exec] PDOException: SQLSTATE[23000]: Integrity constraint violation: 1452 Cannot add or update a child row: a foreign key constraint fails (`bamboo_integration_0`.`pfx_catalog_product_option_type_price`, CONSTRAINT `FK_0404E60DE3B8ACE3BC2CE062A74D0A97` FOREIGN KEY (`option_type_id`) REFERENCES `pfx_catalog_product_option_type_valu)


2) Magento\CatalogImportExport\Model\Export\ProductTest::testExportWithMedia
--
13-Nov-2017 04:15:27 | [exec] Failed asserting that Array &0 (
13-Nov-2017 04:15:27 | [exec]     'additional_images' => 'additional_images'
13-Nov-2017 04:15:27 | [exec]     '/m/a/magento_image.jpg' => '/m/a/magento_image.jpg'
13-Nov-2017 04:15:27 | [exec]     '' => ''
13-Nov-2017 04:15:27 | [exec] ) is identical to Array &0 (
13-Nov-2017 04:15:27 | [exec]     'hide_from_product_page' => 'hide_from_product_page'
13-Nov-2017 04:15:27 | [exec]     '' => ''
13-Nov-2017 04:15:27 | [exec]     '/m/a/magento_image.jpg' => '/m/a/magento_image.jpg'
13-Nov-2017 04:15:27 | [exec] ).

[nmalevanec]

@dmanners integration test fixed.

[dmanners]

@nmalevanec just to keep you updated there is a test that compares the installation database with sample data compared to 2.2-develop and sample data. This is showing differences after your change. I am looking into this and will get back to you about it.

[nmalevanec]

@dmanners Semantic Version Checker fixed.

[devgas]

@okobchenko Fix for #12356 doesn't exist in Magento 2.2.3

[dmanners]

Hi @devgas 2.2.3 was a security patch release and as such was limited in what the contents of this release were. This should be included in the 2.2.4 release though.