Skip to content

Export Products action doesn't consider hide_for_product_page value #8255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
barbanet opened this issue Jan 24, 2017 · 6 comments
Closed

Export Products action doesn't consider hide_for_product_page value #8255

barbanet opened this issue Jan 24, 2017 · 6 comments
Assignees
Labels
bug report Component: ImportExport Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@barbanet
Copy link
Member

Preconditions

  1. Magento 2.1.3
  2. My instance have 1 website and 2 store views for that website.
  3. Tested with 1 product.

Steps to reproduce

  1. Create a simple product and upload an image.
  2. Change the scope to 1 store view.
  3. Set the image as Hide for product page in that store view.
  4. Got to System -> Export.
  5. Select Products and then Continue.

Expected result

  1. The CSV files should have 2 lines. The default values at the first row of values.
  2. The second lines should contain values on sku, store_view_code and hide_from_product_page columns

Actual result

  1. I've created my simple product with an image. Same values for both store views.

01

  1. Then I've changed the scope of my product and I've changed my image properties.

02

  1. Now my product is the same but in 1 store view the image is hidden. Next step was Export productos. The file hasn't information about the second store view changes for that product.

03

  1. Now I've chanegd the product name in the same store view where I have been changed the image properties. The name has changed and the image is still hidden.

04

  1. Now I've exported the file again and the name change is right but the hide_for_product_page value is still empty.

05

@xmav xmav self-assigned this Jan 25, 2017
@xmav xmav added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development 2.0.x labels Jan 26, 2017
@xmav
Copy link
Contributor

xmav commented Jan 26, 2017

@barbanet Thanks for reporting this issue.
We've created internal ticket MAGETWO-63706 to address this issue.

@xmav xmav removed their assignment Jan 26, 2017
@parthpatel147
Copy link

when we can expect Magento will fix issue , cause need to update client when we will be able to import images and and how we can get updated when that internal ticket is updated

@jinalpatelcsoft
Copy link

if ($uploadedFile && $imageNotAssigned) {
$this->_logger->info('&&&&&uploadedFile');
if ($column == self::COL_MEDIA_IMAGE) {
$rowData[$column][] = $uploadedFile;
}
$this->_logger->info('keyvalidate = '.in_array($columnImage,$disabledImages) ." *** ". isset($disabledImages[$columnImage]) );
$mediaGallery[$rowSku][] = [
'attribute_id' => $this->getMediaGalleryAttributeId(),
'label' => isset($rowLabels[$column][$position]) ? $rowLabels[$column][$position] : '',
'position' => $position + 1,
'disabled' => in_array($columnImage , $disabledImages)?1:0,
// 'disabled' => isset($disabledImages[$columnImage]) ? '1' : '0',
'value' => $uploadedFile,
];
if(in_array($columnImage , $disabledImages))
$this->_logger->info('disabled if= '.$columnImage);
else
$this->_logger->info('disabled else= '.$columnImage);
$existingImages[$rowSku][$uploadedFile] = true;
}

I went throught the code and seen that it comes in this code for new images only when uploaded images later we cant do disable , can we have help to the issue , cause site is pending to live due to images

@magento-engcom-team magento-engcom-team added 2.0.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report Component: ImportExport Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed and removed G1 Passed labels Sep 5, 2017
@magento-engcom-team
Copy link
Contributor

@barbanet, thank you for your report.
We've created internal ticket(s) MAGETWO-63706 to track progress on the issue.

@magento-engcom-team magento-engcom-team added 2.2.x Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release labels Oct 11, 2017
@magento-engcom-team magento-engcom-team added Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Oct 11, 2017
@nmalevanec nmalevanec self-assigned this Oct 27, 2017
@okorshenko
Copy link
Contributor

The issue has been fixed and delivered to 2.2-develop branch. Will be available with upcoming patch release

@okorshenko okorshenko added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Dec 1, 2017
@magento-engcom-team
Copy link
Contributor

Hi @barbanet. Thank you for your report.
The issue has been fixed in magento-engcom/magento2ce#1351 by @magento-engcom-team in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Feb 6, 2018
magento-devops-reposync-svc pushed a commit that referenced this issue Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Component: ImportExport Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

8 participants