The left and the right parts of assignment are equal #12515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -91,9 +91,7 @@ protected function _preparelayout() | |||
| public function getFormHtml() | |||
| { | |||
| $formHtml = parent::getFormHtml(); | |||
| if (!$this->_storeManager->isSingleStoreMode() && $this->getVariable()->getId()) { | |||
There was a problem hiding this comment.
I assume this may be simplified to return parent::getFormHtml();
|
@lfluvisotto Thanks for the quick update! |
|
Now method pretty much looks like it can be removed completely, however I would keep it to decrease possibility of any side effects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The left and the right parts of assignment are equal
Description
Unnecessary assignment
Fixed Issues (if relevant)
N/A
Contribution checklist