Skip to content

The left and the right parts of assignment are equal #12515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
magento-team merged 2 commits into from
Dec 1, 2017
Merged

The left and the right parts of assignment are equal #12515

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe9221f
The left and the right parts of assignment are equal
Dec 1, 2017
a3ed399
The left and the right parts of assignment are equal
Dec 1, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions app/code/Magento/Variable/Block/System/Variable/Edit.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,9 +91,7 @@ protected function _preparelayout()
public function getFormHtml()
{
$formHtml = parent::getFormHtml();
if (!$this->_storeManager->isSingleStoreMode() && $this->getVariable()->getId()) {
Copy link
Copy Markdown
Contributor

@ishakhsuvarov ishakhsuvarov Dec 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this may be simplified to return parent::getFormHtml();

$formHtml = $formHtml;
}

return $formHtml;
}

Expand Down