Skip to content

magento/magento2#5035 Cannot subscribe to events with a number in name #12745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

Mobecls
Copy link
Contributor

@Mobecls Mobecls commented Dec 15, 2017

Allow to use digits at names of events

Description

Fixed inconsistence in names in events and sections in system.xml

Fixed Issues

  1. I can not to subscribe on change of all sections in Stores ->Configuration using event admin_system_config_changed_section #5035 I can not to subscribe on change of all sections in Stores ->Configuration using event admin_system_config_changed_section

Manual testing scenarios

  1. M 2.0.7
  2. Create extension, create etc/adminhtml/system.xml there
  3. add section tab with id, that contains number, in my case "b2b" https://drive.google.com/a/interiorwebdesign.com/file/d/0BzTvZltZJMLlemNCOGVwdUM5S00/view?usp=drivesdk
  4. create etc/adminhtml/events.xml and add event listener to listen to changing of this section https://drive.google.com/a/interiorwebdesign.com/file/d/0BzTvZltZJMLlRFpqOEIyc2RKRW8/view?usp=drivesdk

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

  - Allowed to use digits at names of events
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Dec 15, 2017

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@ishakhsuvarov
Copy link
Contributor

Hi @Mobecls
Please sign CLA so that we can proceed with the review and merge of the Pull Request

Thank you

@magento-engcom-team magento-engcom-team added Admin Panel bugfix Fixed in 2.3.x The issue has been fixed in 2.3 release line Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release labels Dec 15, 2017
@miguelbalparda
Copy link
Contributor

There is another fix for this already merged in 2.3 with no backports. Since your fix is pretty much the same, I'll ask internally to see the next steps.

@miguelbalparda miguelbalparda self-assigned this Dec 15, 2017
@Mobecls
Copy link
Contributor Author

Mobecls commented Dec 15, 2017

signed as well

@miguelbalparda
Copy link
Contributor

@aleksmitskevich can you please also sign the CLA?

@miguelbalparda
Copy link
Contributor

miguelbalparda commented Dec 18, 2017

Closing in favor of #12758

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixed in 2.3.x The issue has been fixed in 2.3 release line Progress: reject Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants