Skip to content

magento/magento2#5035 Cannot subscribe to events with a number in name #12758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 22, 2017

Conversation

Mobecls
Copy link
Contributor

@Mobecls Mobecls commented Dec 15, 2017

Allow to use digits at names of events

Description

Fixed inconsistence in names in events and sections in system.xml

Fixed Issues (if relevant)

  1. I can not to subscribe on change of all sections in Stores ->Configuration using event admin_system_config_changed_section #5035 I can not to subscribe on change of all sections in Stores ->Configuration using event admin_system_config_changed_section

Manual testing scenarios

M 2.0.7

  1. Create extension, create etc/adminhtml/system.xml there
  2. add section tab with id, that contains number, in my case "b2b" https://drive.google.com/a/interiorwebdesign.com/file/d/0BzTvZltZJMLlemNCOGVwdUM5S00/view?usp=drivesdk
  3. create etc/adminhtml/events.xml and add event listener to listen to changing of this section https://drive.google.com/a/interiorwebdesign.com/file/d/0BzTvZltZJMLlRFpqOEIyc2RKRW8/view?usp=drivesdk

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Cannot subscribe to events with a number in name
Cannot subscribe to events with a number in name
@magento-engcom-team magento-engcom-team added Admin Panel bugfix Fixed in 2.3.x The issue has been fixed in 2.3 release line Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release labels Dec 15, 2017
@orlangur orlangur self-assigned this Dec 17, 2017
@miguelbalparda
Copy link
Contributor

Am I missing something or this one is a duplicated of #12745?

@orlangur orlangur added this to the December 2017 milestone Dec 18, 2017
@Mobecls
Copy link
Contributor Author

Mobecls commented Dec 18, 2017

Yes, this one is a duplicated of #12745. I created it because the changes were commited by user @aleksmitskevich. The user doesn't have an access to the project. So I couldn't sign the CLA.

@miguelbalparda
Copy link
Contributor

Gotcha, will close the other one. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Progress: accept Release Line: 2.2 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants