Inconsistent Redirect in Admin Notification Controller #13828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This controller has an inconsistent redirect mechanism (than other controllers in admin-notification). This means that if the admin has a different URL, the admin user is returned to the frontend URL of the default store instead.
chickenland
changed the title
ihor-sviziev
requested changes
Feb 27, 2018
| @@ -39,6 +39,7 @@ public function execute() | |||
| $this->messageManager->addException($e, __("We couldn't remove the messages because of an error.")); | |||
| } | |||
| } | |||
| $this->getResponse()->setRedirect($this->_redirect->getRedirectUrl($this->getUrl('*'))); | |||
| $this->_redirect('adminhtml/*/'); | |||
| return; | |||
There was a problem hiding this comment.
This is the end of the method. No need for return here
end of class meant return was un-needed
ihor-sviziev
approved these changes
Feb 28, 2018
|
Hi @ihor-sviziev, thank you for the review. |
|
@chickenland thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository. |
magento-engcom-team
pushed a commit
that referenced
this pull request
Feb 28, 2018
This was referenced Mar 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This controller has an inconsistent redirect mechanism (than other controllers in admin-notification). This means that if the admin has a different URL, the admin user is returned to the frontend URL of the default store instead.
Manual testing scenarios