Skip to content

[Forwardport] Inconsistent Redirect in Admin Notification Controller #14210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dimonovp
Copy link
Contributor

Original Pull Request

#13828

This controller has an inconsistent redirect mechanism (than other controllers in admin-notification). This means that if the admin has a different URL, the admin user is returned to the frontend URL of the default store instead.

Manual testing scenarios

  1. Setup admin to run on a separate domain to the main site
  2. Attempt to mass remove all notifications within admin

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

This controller has an inconsistent redirect mechanism (than other controllers in admin-notification).  This means that if the admin has a different URL, the admin user is returned to the frontend URL of the default store instead.
end of class meant return was un-needed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants