partially backported MAGETWO-83560 : Fixes issue with generating 301 rewrite when changing product URL key on Storeview level #13906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duckchip
changed the title
rogyar
requested changes
Mar 5, 2018
| @@ -205,13 +205,6 @@ public function testExecuteUrlKey( | |||
| ->method('getIsChangedCategories') | |||
| ->will($this->returnValue($isChangedCategories)); | |||
|
|
|||
| $this->urlPersist->expects($this->exactly($expectedDeleteCount))->method('deleteByData')->with([ | |||
There was a problem hiding this comment.
I believe we should remove $expectedDeleteCount variable (parameter) from the function as well since it's unused.
There was a problem hiding this comment.
hi @rogyar
Thanks for your review, I really appreciate it! 👍
Backporting tests always give me headaches 😄 I hope they run smoothly through travis now
There was a problem hiding this comment.
Please, fix the mentioned issue via a new commit. After that the tests will be executed once again.
|
@duckchip are you going to proceed with this PR? |
|
Closed because of failing integration tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of MAGETWO-83560 for 2.1.x projects.
Fixes issue with generating 301 redirect when changing product URL key on Storeview level
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist