Skip to content

Add integration tests for product urls rewrite generation #13567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 28, 2018
Merged

Add integration tests for product urls rewrite generation #13567

merged 2 commits into from
Feb 28, 2018

Conversation

aloross
Copy link

@aloross aloross commented Feb 8, 2018

Adding integration tests for the product url rewrites generation.

Description

This pull request contains integration tests for the product url rewrite generation. We were trying to fix the permanent redirection issue when updating an url_key at store level (see the related issues below).

The issue was caused by $this->urlPersist->deleteByData being executed before the replace process.
We discovered that, in the 2.2-dev branch, the issue was fixed by side effect in this commit: a0d3a63. This PR just provide the tests we were using when fixing the issue but the fix itself is already merged (see: a0d3a63#diff-4e1fd4e484fc5142fc23f8ef0cde6718L53).

Fixed Issues

Related to

Maybe related to

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Feb 8, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

@adrien-louis-r thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@dmanners
Copy link
Contributor

Hi @adrien-louis-r thank you for this PR. I will have a look through the tests and process this pull request for you.

@magento-engcom-team magento-engcom-team merged commit 864f371 into magento:2.2-develop Feb 28, 2018
magento-engcom-team pushed a commit that referenced this pull request Feb 28, 2018
magento-engcom-team pushed a commit that referenced this pull request Feb 28, 2018
@aloross aloross deleted the add-integration-test-product-rewrites branch March 1, 2018 08:02
duckchip pushed a commit to duckchip/magento2 that referenced this pull request Mar 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants