-
Notifications
You must be signed in to change notification settings - Fork 9.4k
[Forwardport] Add integration tests for product urls rewrite generation #14252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Forwardport] Add integration tests for product urls rewrite generation #14252
Conversation
Is there any patch available to fix this issue, or we have to keep waiting for 2.3.0 ( |
@sunilk4y they don't just care about you and me. They're making fun of us and making money for themselves. You can never find a correct way of fixing their bugs in old versions and they leave people with no answer. very selfish. |
@PiroozMB you are acting like a customer and you are not entitled to that in an OSS. Somebody put their effort to fix this in their own free time and you are complaining because you just feel like it. If you need a patch before it’s officialy released you can get the diff and apply it manually via CLI. Just add .diff to any pull request URL and you’ll get the raw diff. |
@miguelbalparda which .diff are you talking about. you see on git thousands threads about this issue and each of them has its own diff. by the way if you are not official magento evelopers and you put this as a solution here on git and you haven't tested it not knowing that it's not working! |
Facing the same issue in magento 2.2.5 version. Also checked the later versions 2.2.7 and 2.3 as well, the issue is still there. |
Facing the same issue with magento 2.3.1 version. Is there any solution? |
Original Pull Request
#13567
Adding integration tests for the product url rewrites generation.
Description
This pull request contains integration tests for the product url rewrite generation. We were trying to fix the permanent redirection issue when updating an url_key at store level (see the related issues below).
The issue was caused by
$this->urlPersist->deleteByData
being executed before the replace process.We discovered that, in the 2.2-dev branch, the issue was fixed by side effect in this commit: a0d3a63. This PR just provide the tests we were using when fixing the issue but the fix itself is already merged (see: a0d3a63#diff-4e1fd4e484fc5142fc23f8ef0cde6718L53).
Fixed Issues
Related to
Maybe related to
Contribution checklist