[Forward Port] [#14089] Add Malaysian Locale Code#14305
Merged
Conversation
orlangur
suggested changes
Mar 24, 2018
| 'mk_MK', /*Macedonian (Macedonia)*/ | ||
| 'mn_Cyrl_MN', /*Mongolian (Mongolia)*/ | ||
| 'ms_Latn_MY', /*Malaysian (Malaysia)*/ | ||
| 'ms_MY', /*Malaysian (Malaysia)*/ |
Contributor
There was a problem hiding this comment.
I doubt this is a typo, should we add both locale codes maybe?
Member
Author
There was a problem hiding this comment.
I will add in a minute ;-)
orlangur
approved these changes
Mar 24, 2018
orlangur
changed the title
Contributor
|
Hi @orlangur, thank you for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add locale code for Malaysian
Description
Add locale config fix typo for Malaysian
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist