-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Preserve user group id when using /V1/customers/:customerId (PUT) #14757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi, @ferrazzuk , I made some changes in your code. I replace condition |
@VladimirZaets awesome, happy to collaborate. |
Hi @ferrazzuk , please, sign CLA, otherwise, we can't process your pull request. |
@VladimirZaets done |
Hi @ferrazzuk , you add new one commit, but the previous commit still exists. We can't merge PR with that commit. You should revert your changes to commit that is before your first commit (052b00119775fdef22a2527a5a53bdb112fd5dda) and make force push with your changes. Thus your first commit will be overridden. |
@VladimirZaets done |
Hi @ferrazzuk , thank you for collaboration. |
Hi @ferrazzuk. Thank you for your contribution. |
@magento-engcom-team my pleasure :) |
Description
When you call /V1/customers/:customerId (PUT) and the customer has a group id already and you don't provide groupId in the request the customer group id is set to 1.
This fix preserves the group id.
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist