Skip to content

Preserve user group id when using /V1/customers/:customerId (PUT) #14757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2018
Merged

Conversation

bydrei
Copy link

@bydrei bydrei commented Apr 18, 2018

Description

When you call /V1/customers/:customerId (PUT) and the customer has a group id already and you don't provide groupId in the request the customer group id is set to 1.
This fix preserves the group id.

Fixed Issues (if relevant)

  1. Updating Customer through rest/all/V1/customers/:id resets group_id if group_id not passed in payload #14663

Manual testing scenarios

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Apr 18, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team magento-engcom-team added this to the April 2018 milestone Apr 18, 2018
@okorshenko okorshenko changed the base branch from 2.1 to 2.1-develop April 18, 2018 16:41
@VladimirZaets
Copy link
Contributor

Hi, @ferrazzuk , I made some changes in your code. I replace condition is_null to strict chek === null.
Thank you for collaboration.

@bydrei
Copy link
Author

bydrei commented Apr 19, 2018

@VladimirZaets awesome, happy to collaborate.

@VladimirZaets
Copy link
Contributor

Hi @ferrazzuk , please, sign CLA, otherwise, we can't process your pull request.
Your commit hasn't email setting. What would we process your pull request you should add email to your git settings and make a new commit instead of previous.

@bydrei
Copy link
Author

bydrei commented Apr 20, 2018

@VladimirZaets done

@VladimirZaets
Copy link
Contributor

Hi @ferrazzuk , you add new one commit, but the previous commit still exists. We can't merge PR with that commit. You should revert your changes to commit that is before your first commit (052b00119775fdef22a2527a5a53bdb112fd5dda) and make force push with your changes. Thus your first commit will be overridden.

@bydrei
Copy link
Author

bydrei commented May 2, 2018

@VladimirZaets done

@VladimirZaets
Copy link
Contributor

Hi @ferrazzuk , thank you for collaboration.
The Pull Request will be merged soon.

@magento-engcom-team
Copy link
Contributor

Hi @ferrazzuk. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.1.15 release.

@bydrei
Copy link
Author

bydrei commented May 3, 2018

@magento-engcom-team my pleasure :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants