-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Changed the length of the remote_ip field to store ipv6 addresses #14976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed the length of the remote_ip field to store ipv6 addresses #14976
Conversation
…nto#10395 Signed-off-by: George Schiopu <[email protected]>
Hi @miguelbalparda, thank you for the review. |
@georgeschiopu thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository. |
Hi @georgeschiopu. Thank you for your contribution. |
Thanks @georgeschiopu! Any chance you can backport this to the other branches? |
Hi @miguelbalparda , I'll try to do so this week. |
Expands the
remote_ip
field to 45 characters in both thesales_order
andquote
tables, to cope with the ipv6 addresses, otherwise they get truncated.Fixed Issues (if relevant)
Manual testing scenarios
bin/magento setup:upgrade
and check both tables mentioned to check for the changes; also, check the versions of the modules insetup_module
Contribution checklist