Skip to content

[Backport] Changed the length of the remote_ip field to store ipv6 addresses #15140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

dmytro-ch
Copy link
Contributor

Original PR: #14976.

Expands the remote_ip field to 45 characters in both the sales_order and quote tables, to cope with the ipv6 addresses, otherwise, they get truncated.

Fixed Issues (if relevant)

  1. REMOTE_IP gets saved partially when using IPV6 #10395 : REMOTE_IP gets saved partially when using IPV6

Manual testing scenarios

  1. trigger a bin/magento setup:upgrade and check both tables mentioned to check for the changes; also, check the versions of the modules in setup_module

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@dmytro-ch dmytro-ch self-assigned this May 10, 2018
@dmytro-ch dmytro-ch requested a review from rogyar May 10, 2018 15:28
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented May 10, 2018

CLA assistant check
All committers have signed the CLA.

@rogyar rogyar assigned rogyar and unassigned dmytro-ch May 10, 2018
@magento-engcom-team magento-engcom-team added this to the May 2018 milestone May 10, 2018
@magento-engcom-team magento-engcom-team added Release Line: 2.1 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels May 10, 2018
@magento-engcom-team
Copy link
Contributor

@dmytro-ch thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@okorshenko okorshenko removed this from the May 2018 milestone May 31, 2018
@VladimirZaets VladimirZaets self-assigned this Jun 1, 2018
@VladimirZaets
Copy link
Contributor

Hi, @dmytro-ch, due to Magento backward-compatible guide we can't make changes to DB schema in Magento 2.1 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants