Skip to content

[Fix] forgot to add lowercase conversion on grouped product assignation #15312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jalogut
Copy link
Contributor

@jalogut jalogut commented May 18, 2018

Forgot to add lowercase conversion on grouped product assignation after changes done in MAGETWO-67240

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

…on after changes done in MAGETWO-67240

- See changes done for MAGETWO-67240 here magento@02596b7#diff-b876c962d83b3bee42acba83af842309
@dmanners
Copy link
Contributor

Hi @jalogut we have #12853 PR that was merged into 2.3. Could you please check as there is some extra changes in this from your PR. I wonder if we need a few more changes in your PR to complete this fix.

@magento-engcom-team
Copy link
Contributor

Hi @jalogut. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.5 release.

Please, consider porting this solution across release lines.
You may use Porting tool to port commits automatically.

@jalogut
Copy link
Contributor Author

jalogut commented May 25, 2018

Sorry, what is this porting tool exactly for? Never done a port before and I do not really understand what it does. Could you maybe explain it with an example? Thanks.

@dmanners
Copy link
Contributor

Hi @jalogut this tool has been created to allow you to take your pull request and port it to other versions of Magento. By using the url https://porting.engcom.dev.magento.com/, providing the right github information and supplying your pull request url it will attempt to create a PR to 2.1 and 2.3 from your pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants