Skip to content

[Forwardport] [Fix] forgot to add lowercase conversion on grouped product assignation #16741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

hitesh-wagento
Copy link
Contributor

Original Pull Request

#15312
Forgot to add lowercase conversion on grouped product assignation after changes done in MAGETWO-67240

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Component: GroupedImportExport labels Jul 12, 2018
@magento-engcom-team
Copy link
Contributor

Hi @hitesh-wagento. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@hitesh-wagento
Copy link
Contributor Author

Hi @sidolov

Any update on this PR ?

Thanks

@sidolov
Copy link
Contributor

sidolov commented Jul 19, 2018

Hi @hitesh-wagento , your PR awaiting for delivery.

@magento-engcom-team magento-engcom-team merged commit 8169e5e into magento:2.3-develop Jul 20, 2018
magento-engcom-team pushed a commit that referenced this pull request Jul 20, 2018
@magento-engcom-team
Copy link
Contributor

Hi @hitesh-wagento. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

@hitesh-wagento hitesh-wagento deleted the 2.3-fix-sku-format-for-grouped-product-import branch September 6, 2018 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup Component: GroupedImportExport Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants