Skip to content

Conversation

@wokisajn
Copy link

@wokisajn wokisajn commented May 18, 2018

…me SKU

Warning when try to add product with the same SKU

Description

Before changes when you try to save non-exist product with same SKU, attribute was incremented and it is wrong for business uses.
Now when you try to save product with same SKU, magento return a warning about it.

Fixed Issues (if relevant)

#7121: It's possible to create multiple products with the same SKU
#7121

Manual testing scenarios

  1. Add a new product by panel or API with SKU which is already in database

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented May 18, 2018

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ wokisajn
❌ ecomchallenger


ecomchallenger seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@dmanners dmanners added the Event: WroCD Contribution day in Wro label May 18, 2018
wokisajn and others added 3 commits May 18, 2018 16:09
… (Integration tests, improvement for product duplication)
…-products-same-sku

ISSUE:7121 - warning when try to create multiple products with the same SKU (product duplication improvement and test)
@ecomchallenger
Copy link

@magento-cicd2 thanks for information. I've already signed the CLA.

@dmanners
Copy link
Contributor

Hi @wokisajn thank you for this pull requests. We have decided that we will look into this task into a bit more detail during the import/export improvements community project. As such I will close this PR as it should be covered by magento-engcom/import-export-improvements#119 and some further tasks. Thank you for the time you have invested here.

@dmanners dmanners closed this Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Event: WroCD Contribution day in Wro

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants