Skip to content

Fixes in ui module #15512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 27, 2018
Merged

Fixes in ui module #15512

merged 2 commits into from
May 27, 2018

Conversation

mhauri
Copy link

@mhauri mhauri commented May 25, 2018 •
edited
Loading

Description

This PR fixes two issues in the Magento/Ui Module:

  1. getConfiguration() invoked with 1 parameter, 0 required, see Magento/Ui/Component/Bookmark.php on line 85 and 89

  2. Class Magento\Ui\Component\Control\ActionPool constructor invoked with 3 parameters, 2 required. see Magento/Ui/Test/Unit/Component/Control/ActionPoolTest.php on line 87

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@osrecio osrecio self-assigned this May 25, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.5 milestone May 25, 2018
@osrecio
Copy link
Member

osrecio commented May 25, 2018

Hi @mhauri ,
Thanks for your contribution.
I will process this PR as soon as possible.

@magento-engcom-team magento-engcom-team merged commit c261463 into magento:2.2-develop May 27, 2018
magento-engcom-team pushed a commit that referenced this pull request May 27, 2018
ENGCOM-1678: Fixes in ui module #15512
e43cd18
@magento-engcom-team
Copy link
Contributor

Hi @mhauri. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.5 release.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

@mhauri mhauri mentioned this pull request May 28, 2018
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@osrecio osrecio

Labels
Component: Ui Progress: accept Release Line: 2.2
Projects
None yet
Milestone
Release: 2.2.5
Development

Successfully merging this pull request may close these issues.
3 participants
@mhauri @osrecio @magento-engcom-team