Skip to content

[Forwardport] Fixes in ui module #15551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 30, 2018
Merged

[Forwardport] Fixes in ui module #15551

merged 2 commits into from
May 30, 2018

Conversation

mhauri
Copy link

@mhauri mhauri commented May 28, 2018 •
edited
Loading

Original Pull Request

#15512

Description

This PR fixes two issues in the Magento/Ui Module:

  1. getConfiguration() invoked with 1 parameter, 0 required, see Magento/Ui/Component/Bookmark.php on line 85 and 89

  2. Class Magento\Ui\Component\Control\ActionPool constructor invoked with 3 parameters, 2 required. see Magento/Ui/Test/Unit/Component/Control/ActionPoolTest.php on line 87

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@osrecio osrecio self-assigned this May 28, 2018
@osrecio
Copy link
Member

osrecio commented May 29, 2018

Thanks @mhauri . I will process your PR asap.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone May 29, 2018
@magento-engcom-team magento-engcom-team merged commit b6cb73c into magento:2.3-develop May 30, 2018
magento-engcom-team pushed a commit that referenced this pull request May 30, 2018
ENGCOM-1701: [Forwardport] Fixes in ui module #15551
d26ad7d
@magento-engcom-team
Copy link
Contributor

Hi @mhauri. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@osrecio osrecio

Labels
Component: Ui Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mhauri @osrecio @magento-engcom-team