Skip to content

Submitting search form (mini) with enter key fires event handlers bound by jquery twice #16139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

gelanivishal
Copy link
Contributor

Original Pull Request

#15340

Description

When submitting the search form in the header with the enter key on the keyboard, event handlers that were bound to the form submit (through jQuery) are fired twice.

Fixed Issues (if relevant)

  1. Submitting search form (mini) with enter key fires event handlers bound by jquery twice #13793: Submitting search form (mini) with enter key fires event handlers bound by jquery twice

Manual testing scenarios

  1. Create a javascript which adds an event handler to the form submit
  2. $('#search_mini_form').on('submit', function(e) {
    console.log('listening for form submit');
    });
  3. Submit the search form in the header with a value by pressing the enter button

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

gelanivishal and others added 18 commits May 23, 2018 14:28
[Backport] Fixed Purchased Order Form button should visible properly
[Backport] Fixed set template syntax issue
[Backport] Updated font-size variable and standardize #ToDo UI
[Backport] Moved css from media #TODO
[Backport] magento#14063 - Wrong invoice prefix in multistore setup due to default stor…
[Backport] magento#12820 - Wrong annotation in _toOptionArray - magento/framework/Data/…
[Backport] Wrong annotation in _toOptionArray : lib\internal\Magento\Framework\D…
[Backport] ISSUE-11477 - fixed Swagger response for searchCriteria
[Backport] Adding support for variadic arguments' method in generated proxy c…
@orlangur
Copy link
Contributor

Commit history is incorrect. Please check it prior to PR creation.

@orlangur orlangur closed this Jun 14, 2018
@gelanivishal gelanivishal deleted the 2.1-develop-PR-back-15340 branch June 21, 2018 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants