-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Submitting search form (mini) with enter key fires event handlers bound by jquery twice #16139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
gelanivishal
wants to merge
18
commits into
magento:2.1-develop
from
gelanivishal:2.1-develop-PR-back-15340
Closed
Submitting search form (mini) with enter key fires event handlers bound by jquery twice #16139
gelanivishal
wants to merge
18
commits into
magento:2.1-develop
from
gelanivishal:2.1-develop-PR-back-15340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Backport] Fixed Purchased Order Form button should visible properly
[Backport] Fixed set template syntax issue
[Backport] Updated font-size variable and standardize #ToDo UI
[Backport] Moved css from media #TODO
[Backport] Fixed typo error
[Backport] magento#14063 - Wrong invoice prefix in multistore setup due to default stor…
[Backport] set correct annotation
[Backport] magento#12820 - Wrong annotation in _toOptionArray - magento/framework/Data/…
[Backport] Fixxes magento#15565
[Backport] Wrong annotation in _toOptionArray : lib\internal\Magento\Framework\D…
[Backport] ISSUE-11477 - fixed Swagger response for searchCriteria
[Backport] Adding support for variadic arguments' method in generated proxy c…
Commit history is incorrect. Please check it prior to PR creation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#15340
Description
When submitting the search form in the header with the enter key on the keyboard, event handlers that were bound to the form submit (through jQuery) are fired twice.
Fixed Issues (if relevant)
Manual testing scenarios
console.log('listening for form submit');
});
Contribution checklist