Setting deploy mode to production with --skip-compilation flag should not clear generated code

[platformvaimo]

Description

Changing the deploy mode to production using the --skip-compilation flag will remove the generated code in generated/code/ and generated/metadata/.

The expected result is that generated/code/ and generated/metadata/ should not be cleared.

This was introduced in ea57b46#diff-de930b059902896ae8ce118b11024cbaR108. It is safe to remove as the deploy:mode:set command will clear the folder when the --skip-compilation flag is not used.

Manual testing scenarios

1. Make sure you are in developer mode: php bin/magento deploy:mode:set developer
2. php bin/magento setup:di:compile
3. php bin/magento deploy:mode:set production --skip-compilation
4. ls -la generated/metadata/ should contain files

[magento-cicd2]

All committers have signed the CLA.

[magento-engcom-team]

Hi @platformvaimo. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on Pull Request changes
• @magento-engcom-team give me new test instance - deploy NEW test instance based on Pull Request changes
• @magento-engcom-team give me {$VERSION} instance - deploy Vanilla Magento instance for Issue or Pull Request

For more details, please, review the Magento Contributor Assistant documentation

[orlangur]

Thanks @platformvaimo for comprehensive investigation, appreciate that 👍

Note for QA: need to be checked that:

• there is no regression ofMAGETWO-68928: Fatal error after disabling module
• deploy:mode:set command will clear the folder when the --skip-compilation flag is not used (all combinations for dev, prod, default modes please)

[magento-engcom-team]

Hi @orlangur, thank you for the review.
ENGCOM-2029 has been created to process this Pull Request

[magento-engcom-team]

@platformvaimo thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

[magento-engcom-team]

Hi @platformvaimo. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.6 release.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.