[Forwardport] Setting deploy mode to production with --skip-compilation flag should…

[gelanivishal]

Original Pull Request

#16211

Description

Changing the deploy mode to production using the --skip-compilation flag will remove the generated code in generated/code/ and generated/metadata/.

The expected result is that generated/code/ and generated/metadata/ should not be cleared.

This was introduced in ea57b46#diff-de930b059902896ae8ce118b11024cbaR108. It is safe to remove as the deploy:mode:set command will clear the folder when the --skip-compilation flag is not used.

Manual testing scenarios

1. Make sure you are in developer mode: php bin/magento deploy:mode:set developer
2. php bin/magento setup:di:compile
3. php bin/magento deploy:mode:set production --skip-compilation
4. ls -la generated/metadata/ should contain files

[magento-engcom-team]

Hi @gelanivishal. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[magento-engcom-team]

Hi @orlangur, thank you for the review.
ENGCOM-2199 has been created to process this Pull Request

[magento-engcom-team]

Hi @gelanivishal. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.