-
Notifications
You must be signed in to change notification settings - Fork 9.4k
#16273: Fix bug in method getUrlInStore() of product model #16308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
vasilii-b
wants to merge
317
commits into
magento:2.2-develop
from
vasilii-b:#16273-product-geturlinstore-wrong-link_mage22
Closed
#16273: Fix bug in method getUrlInStore() of product model #16308
vasilii-b
wants to merge
317
commits into
magento:2.2-develop
from
vasilii-b:#16273-product-geturlinstore-wrong-link_mage22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dating product attributes through API
…dating product attributes through API
…15521 - Merge Pull Request magento#15521 from diedburn/magento2:fix_breadcrumbs_encoding - Merged commits: 1. 213e11d 2. 603de52 3. e95f3f7
…oesn't update after deleting category
…oesn't update after deleting category
… different website
…tag and doesn't show… magento#15532 - Merge Pull Request magento#15532 from phoenix128/magento2:issue-15501-missing-meta-title-tag - Merged commits: 1. 0a38b84 2. 85ac3be 3. 432cf00 4. 1413d65
…dating product attributes through API
[TSG] Backporting for 2.2 (pr32) (2.2.6)
…om/magento2ce into bulk-api-backported
…dating product attributes through API
Bulk api backported
…ento#16379 - Merge Pull Request magento#16379 from hitesh-wagento/magento2:wrong-password-checkout - Merged commits: 1. 4f976e7 2. 55d1c15
…rror key in product import magento#16389
…mage/calendar when setting `numberOfM… magento#16279
Accepted Public Pull Requests: - magento#13509: Use constant time string comparison in FormKey validator (by @p0pr0ck5) - magento#16389: [Backport 2.2] Use correct error message for duplicate error key in product import (by @gelanivishal) - magento#16379: [Changed password placeholder text in checkout page] (by @hitesh-wagento) - magento#16093: When searching for the title if search for all the segments that has � (by @rsantellan) - magento#16279: MAGETWO-61209: Backport - Fixed issue magento#7379 with mage/calendar when setting `numberOfM� (by @vasilii-b) - magento#16333: Add metadata title in unit test (by @slackerzz) - magento#16217: Admin controller product set save refactor (by @AnshuMishra17) - magento#15339: Fixed set template syntax in block file (by @namratachangani) Fixed GitHub Issues: - magento#16378: Wrong placeholder for password field in the checkout page (reported by @mohitka) has been fixed in magento#16379 by @hitesh-wagento in 2.2-develop branch Related commits: 1. 4f976e7 2. 55d1c15 - magento#7379: Calendar widget (jQuery UI DatePicker) with numberOfMonths = 2 or more (reported by @atihomirov) has been fixed in magento#16279 by @vasilii-b in 2.2-develop branch Related commits: 1. de533cc - magento#15345: Template syntax in block file (reported by @vgelani) has been fixed in magento#15339 by @namratachangani in 2.2-develop branch Related commits: 1. efd58e3 2. 86b9895 3. c1ce795 4. 5118361
Fixed issues: - MAGETWO-87589: [Magento Cloud] - Issue with polluted database when updating product attributes through API
…store-wrong-link_mage22' into magento#16273-product-geturlinstore-wrong-link_mage22
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bugfix
Component: Store
Partner: Atwix
Pull Request is created by partner Atwix
partners-contribution
Pull Request is created by Magento Partner
Release Line: 2.2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR reference changes how/what is returned when
product
model methodgetUrlInStore()
is called$product->getUrlInStore()
.Problem is in how the current store is checked and what is returned based on it.
Fixed Issues
Manual testing scenarios
For issue 1 - please see the issue description.
For issue 2:
.phtml
file, list.phtml for example, call methodgetUrlInStore()
for a product.Expected Result
Store code is not added into product url
Actual Result
Store code is added into product url
Contribution checklist