Skip to content

MSI-1411: Add new rule to copy paste detector blacklist to avoid cove… - #16508

Merged
magento-engcom-team merged 1 commit into
magento:2.3-developfrom
VitaliyBoyko:MSI-1411-add-new-rule-to-copy-paste-detector-blacklist
Jul 4, 2018
Merged

MSI-1411: Add new rule to copy paste detector blacklist to avoid cove…#16508
magento-engcom-team merged 1 commit into
magento:2.3-developfrom
VitaliyBoyko:MSI-1411-add-new-rule-to-copy-paste-detector-blacklist

Conversation

@VitaliyBoyko

@VitaliyBoyko VitaliyBoyko commented Jul 3, 2018 •
edited by ishakhsuvarov
Loading

Copy link
Copy Markdown
Contributor

Description

In the MSI modules all fixtures for tests are in <Module_Name>/Test/_data which is different from Magento current implementations.
In order to avoid falling copy paste detector tests on the fixtures has been added a new rule to the blacklist.

Fixed Issues (if relevant)

Static test falling

PS. It's very important for MSI ;)

@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Jul 3, 2018
@magento-engcom-team

magento-engcom-team commented Jul 3, 2018

Copy link
Copy Markdown
Contributor

Hi @VitaliyBoyko. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@orlangur orlangur self-assigned this Jul 3, 2018
@orlangur

orlangur commented Jul 3, 2018

Copy link
Copy Markdown
Contributor

@VitaliyBoyko could you give more insight why do we need copy-pasted fixtures? Also, any contribution must be delivered to 2.2-develop first, no matter MSI-related or not.

@VitaliyBoyko

VitaliyBoyko commented Jul 4, 2018

Copy link
Copy Markdown
Contributor Author

Hi @orlangur
Thank you for review.

MSI modules have own fixtures which are similar to core ones. Similar, but not exactly the same. Including code from core gonna bring more complexity than we suppress possible copypaste parts.

any contribution must be delivered to 2.2-develop
There is some rule in Contribution Guide? I could not found it :(
Could you please share these requirements or just explain why we need changes related only to 2.3 in 2.2 develop.

Thank you!

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Jul 4, 2018
@ishakhsuvarov

ishakhsuvarov commented Jul 4, 2018

Copy link
Copy Markdown
Contributor

Hi @orlangur @VitaliyBoyko
I think we can safely deliver this to 2.2. There is not hard requirement in place regarding merge and delivery sequence when pull request is submitted to 2.3.

@magento-engcom-team

magento-engcom-team commented Jul 4, 2018

Copy link
Copy Markdown
Contributor

Hi @ishakhsuvarov, thank you for the review.
ENGCOM-2180 has been created to process this Pull Request

@VitaliyBoyko

VitaliyBoyko commented Jul 4, 2018

Copy link
Copy Markdown
Contributor Author

Hi @ishakhsuvarov
Deal. Thank you!

@orlangur

orlangur commented Jul 4, 2018

Copy link
Copy Markdown
Contributor

@ishakhsuvarov,

There is not hard requirement in place regarding merge and delivery sequence when pull request is submitted to 2.3.

At least some time ago the process was to put 2.3 contribution on hold until it is processed for 2.2.

orlangur
orlangur approved these changes Jul 4, 2018
View reviewed changes

@orlangur orlangur left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to discussion in Slack: fixtures are full of copy-paste but it is not possible to refactor them quickly.

@magento-engcom-team

magento-engcom-team commented Jul 4, 2018

Copy link
Copy Markdown
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-2180 has been created to process this Pull Request

@orlangur

orlangur commented Jul 4, 2018

Copy link
Copy Markdown
Contributor

@VitaliyBoyko,

why we need changes related only to 2.3 in 2.2 develop.

It is important to have in 2.3 rules which are equally or more strict than in 2.2 for various static tests. If we won't port it into 2.2 somebody may need to perform an unneeded refactoring of fixture not knowing it is simply ignored in 2.3.

@ishakhsuvarov

ishakhsuvarov commented Jul 4, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

@orlangur Currently the whole dev directory, which contains integration text fixtures is blacklisted. Thus, creating another location for fixtures and creating a blacklist for it makes it equally strict.

UPD: Not that I am against porting this solution. I am just not seeing a point in requiring this PR to be merged in 2.2 first.

@orlangur

orlangur commented Jul 4, 2018

Copy link
Copy Markdown
Contributor

Thus, creating another location for fixtures and creating a blacklist for it makes it equally strict.

What I meant is that without porting 2.3 would be less strict.

a point in requiring this PR to be merged in 2.2 first.

It is a generic rule, isn't it? Anything applicable to 2.2 should be merged there first.

@magento-engcom-team
magento-engcom-team merged commit 7abdafd into magento:2.3-develop Jul 4, 2018
magento-engcom-team pushed a commit that referenced this pull request Jul 4, 2018
Stanislav Idolov
ENGCOM-2180: MSI-1411: Add new rule to copy paste detector blacklist …
2ff3421 
…to avoid cove… #16508
@magento-engcom-team

magento-engcom-team commented Jul 4, 2018

Copy link
Copy Markdown
Contributor

Hi @VitaliyBoyko. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

This was referenced Jul 4, 2018
Merged
Closed
Closed
This was referenced Jul 4, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@VitaliyBoyko VitaliyBoyko mentioned this pull request Jul 11, 2018
Closed
altdovydas pushed a commit to altdovydas/magento2 that referenced this pull request Aug 6, 2026
@magento-engcom-team
ENGCOM-2180: MSI-1411: Add new rule to copy paste detector blacklist …
92233f9 
…to avoid cove… magento#16508

 - Merge Pull Request magento#16508 from VitaliyBoyko/magento2:MSI-1411-add-new-rule-to-copy-paste-detector-blacklist
 - Merged commits:
   1. 7abdafd
altdovydas pushed a commit to altdovydas/magento2 that referenced this pull request Aug 6, 2026
@magento-engcom-team
🔃 [EngCom] Public Pull Requests - 2.3-develop
d7aafe9 
Accepted Public Pull Requests:
 - magento#16484: Declare module namespace before template path name(Magento_Sales::order/history.phtml). (by @mage2pratik)
 - magento#16412: Admin tabs order not working properly (by @tiagosampaio)
 - magento#16466: [Forwardport] Move breadcrumb json configuration to viewmodel (by @gelanivishal)
 - magento#16391: [Forwardport] Fixes updating wishlist item if an item object is passed instead its id. (by @eduard13)
 - magento#15732: [Forwardport] Resolve Knockout non-unique elements id in console error (by @vijay-wagento)
 - magento#16508: MSI-1411: Add new rule to copy paste detector blacklist to avoid cove… (by @VitaliyBoyko)


Fixed GitHub Issues:
 - magento#16174: Admin tabs order not working properly (reported by @tiagosampaio) has been fixed in magento#16412 by @tiagosampaio in 2.3-develop branch
   Related commits:
     1. e04b7ca
     2. 447667f
     3. 0dd4268
     4. 9301ccb
     5. c2b5c7a
     6. 024384a
     7. d35b094
     8. 63cc8e6
     9. fe307c7

 - magento#15348: Multiple Payment Methods Enabled is giving error in console "Found 3 Elements with non - unique Id" (reported by @neeta-wagento) has been fixed in magento#15732 by @vijay-wagento in 2.3-develop branch
   Related commits:
     1. 5822e44
     2. 4847b46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@orlangur orlangur orlangur approved these changes
@ishakhsuvarov ishakhsuvarov ishakhsuvarov approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@orlangur orlangur

@ishakhsuvarov ishakhsuvarov

Labels

Cleanup Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3

Projects

None yet

Milestone

Release: 2.3.0

Development

Successfully merging this pull request may close these issues.

4 participants

@VitaliyBoyko @magento-engcom-team @orlangur @ishakhsuvarov