Skip to content

Admin tabs order not working properly - #16412

Merged
magento-engcom-team merged 9 commits into
magento:2.3-developfrom
tiagosampaio:hotfix/2.3-develop-16174
Jul 4, 2018
Merged

Admin tabs order not working properly#16412
magento-engcom-team merged 9 commits into
magento:2.3-developfrom
tiagosampaio:hotfix/2.3-develop-16174

Conversation

@tiagosampaio

@tiagosampaio tiagosampaio commented Jun 26, 2018 •
edited by sidolov
Loading

Copy link
Copy Markdown
Member
  • Created a method to reorder the tabs which is less complex and works better.

Description

When you add 2 or more tabs to admin area, like order view page, by using the method addTabAfter and the second new tab is placed after the first new tab the sort order does not work as expected.

More details in the issue.

Fixed Issues

  1. Admin tabs order not working properly #16174: Issue title

Manual testing scenarios

Described in the issue.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Original PR

#16175

@magento-engcom-team

magento-engcom-team commented Jun 26, 2018

Copy link
Copy Markdown
Contributor

Hi @tiagosampaio. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Jul 2, 2018
@magento-engcom-team magento-engcom-team mentioned this pull request Jul 4, 2018
Closed
@magento-engcom-team
magento-engcom-team merged commit fe307c7 into magento:2.3-develop Jul 4, 2018
magento-engcom-team pushed a commit that referenced this pull request Jul 4, 2018
Stanislav Idolov
ENGCOM-2158: Admin tabs order not working properly #16412
45078f2
@magento-engcom-team

magento-engcom-team commented Jul 4, 2018

Copy link
Copy Markdown
Contributor

Hi @tiagosampaio. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

@tiagosampaio

tiagosampaio commented Jul 4, 2018

Copy link
Copy Markdown
Member Author

Thank you @magento-engcom-team. It's nice to hear that.

@mageprince mageprince mentioned this pull request Jul 8, 2018
Closed
4 tasks
@tiagosampaio
tiagosampaio deleted the hotfix/2.3-develop-16174 branch July 13, 2018 16:43
@mage2pratik mage2pratik mentioned this pull request Jul 18, 2018
Closed
4 tasks
@kiatng kiatng mentioned this pull request Dec 18, 2020
Merged
3 tasks
altdovydas pushed a commit to altdovydas/magento2 that referenced this pull request Aug 6, 2026
@magento-engcom-team
ENGCOM-2158: Admin tabs order not working properly magento#16412
9ba4c6b 
 - Merge Pull Request magento#16412 from tiagosampaio/magento2:hotfix/2.3-develop-16174
 - Merged commits:
   1. e04b7ca
   2. 447667f
   3. 0dd4268
   4. 9301ccb
   5. c2b5c7a
   6. 024384a
   7. d35b094
   8. 63cc8e6
   9. fe307c7
altdovydas pushed a commit to altdovydas/magento2 that referenced this pull request Aug 6, 2026
@magento-engcom-team
🔃 [EngCom] Public Pull Requests - 2.3-develop
d7aafe9 
Accepted Public Pull Requests:
 - magento#16484: Declare module namespace before template path name(Magento_Sales::order/history.phtml). (by @mage2pratik)
 - magento#16412: Admin tabs order not working properly (by @tiagosampaio)
 - magento#16466: [Forwardport] Move breadcrumb json configuration to viewmodel (by @gelanivishal)
 - magento#16391: [Forwardport] Fixes updating wishlist item if an item object is passed instead its id. (by @eduard13)
 - magento#15732: [Forwardport] Resolve Knockout non-unique elements id in console error (by @vijay-wagento)
 - magento#16508: MSI-1411: Add new rule to copy paste detector blacklist to avoid cove… (by @VitaliyBoyko)


Fixed GitHub Issues:
 - magento#16174: Admin tabs order not working properly (reported by @tiagosampaio) has been fixed in magento#16412 by @tiagosampaio in 2.3-develop branch
   Related commits:
     1. e04b7ca
     2. 447667f
     3. 0dd4268
     4. 9301ccb
     5. c2b5c7a
     6. 024384a
     7. d35b094
     8. 63cc8e6
     9. fe307c7

 - magento#15348: Multiple Payment Methods Enabled is giving error in console "Found 3 Elements with non - unique Id" (reported by @neeta-wagento) has been fixed in magento#15732 by @vijay-wagento in 2.3-develop branch
   Related commits:
     1. 5822e44
     2. 4847b46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@VladimirZaets VladimirZaets

Labels

Award: bug fix Component: Backend Progress: accept Release Line: 2.3

Projects

None yet

Milestone

Release: 2.3.0

Development

Successfully merging this pull request may close these issues.

4 participants

@tiagosampaio @magento-engcom-team @VladimirZaets @gelanivishal