Skip to content

[Backport] Admin tabs order not working properly #16624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

[Backport] Admin tabs order not working properly #16624

wants to merge 8 commits into from

Conversation

mageprince
Copy link
Contributor

Original Pull Request

#16412

  • Created a method to reorder the tabs which is less complex and works better.

Description

When you add 2 or more tabs to admin area, like order view page, by using the method addTabAfter and the second new tab is placed after the first new tab the sort order does not work as expected.

More details in the issue.

Fixed Issues

  1. Admin tabs order not working properly #16174: Issue title

Manual testing scenarios

Described in the issue.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @mageprince. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@sidolov
Copy link
Contributor

sidolov commented Jul 25, 2018

@mageprince , this changes already delivered in the scope of another pull request: #16175
I'm closing this one as not relevant.

@sidolov sidolov closed this Jul 25, 2018
@mageprince mageprince deleted the 2.2-develop-PR-port-16412 branch July 25, 2018 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants