Skip to content

[Forwardport] Add compare list link to success message after adding a product #16757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 10, 2018
Merged

[Forwardport] Add compare list link to success message after adding a product #16757

merged 6 commits into from
Aug 10, 2018

Conversation

gelanivishal
Copy link
Contributor

@gelanivishal gelanivishal commented Jul 12, 2018 •
edited by sidolov
Loading

Original Pull Request

#13862

Description

If I add a product to the compare list, I want to go the compare list directly after that in many cases without having to search for a link. Thus, the link has been added to the success message now.

Manual testing scenarios

  1. Go to a product view page
  2. Click "Add to compare"
  3. Check if the success message contains a link to the compare list:
    grafik

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @gelanivishal. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@nuzil nuzil self-requested a review July 12, 2018 21:33
@VladimirZaets VladimirZaets self-assigned this Jul 12, 2018
@orlangur orlangur changed the title Add compare list link to success message after adding a product [Forwardport] Add compare list link to success message after adding a product Jul 13, 2018
@orlangur
Copy link
Contributor

@gelanivishal don't forget to add Backport/Forwardport into issue title.

@nuzil
Copy link
Contributor

nuzil commented Jul 13, 2018

@gelanivishal please fix Static and integration tests

nuzil
nuzil requested changes Jul 13, 2018
View reviewed changes
app/code/Magento/Catalog/etc/frontend/di.xml Outdated
<arguments>
<argument name="galleryImagesConfig" xsi:type="array">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you wrongly resolved conflicts while doing this Forwardport. Can you please check this part and resolve it correctly?

@gelanivishal
Copy link
Contributor Author

@nuzil I have fixed request chagnes.

nuzil
nuzil requested changes Jul 15, 2018
View reviewed changes
Copy link
Contributor

@nuzil nuzil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gelanivishal can you please fix failed tests?

app/code/Magento/Catalog/etc/frontend/di.xml Outdated
@@ -82,20 +82,11 @@
<type name="Magento\Catalog\Block\Product\View\Gallery">
<arguments>
<argument name="galleryImagesConfig" xsi:type="array">
<item name="small_image" xsi:type="array">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi
Looks like you accidentally removed working part of code, can you please review your changes? As reference you can use this commit from original PR
https://github.com/magento/magento2/pull/13862/files#diff-da4fdd9a985964091b2bbe0a3722ab77

@gelanivishal
Copy link
Contributor Author

@nuzil Please review at once.

@gelanivishal
Copy link
Contributor Author

@orlangur Please review requested changes.

@nuzil
Copy link
Contributor

nuzil commented Jul 23, 2018

Hi @gelanivishal you still have failed Static tests, can you please review this changes?

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Aug 7, 2018
@magento-engcom-team magento-engcom-team merged commit e7463c1 into magento:2.3-develop Aug 10, 2018
magento-engcom-team pushed a commit that referenced this pull request Aug 10, 2018
ENGCOM-2681: [Forwardport] Add compare list link to success message a…
2e5e1f5 
…fter adding a product #16757
@magento-engcom-team
Copy link
Contributor

Hi @gelanivishal. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuzil nuzil nuzil requested changes

Assignees

@osrecio osrecio

@VladimirZaets VladimirZaets

Labels
Area: Frontend Component: Catalog Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.0
Development

Successfully merging this pull request may close these issues.
7 participants
@gelanivishal @magento-engcom-team @orlangur @nuzil @osrecio @VladimirZaets @avstudnitz