Skip to content

Add compare list link to success message after adding a product #13862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

avstudnitz
Copy link
Contributor

@avstudnitz avstudnitz commented Feb 27, 2018

Description

If I add a product to the compare list, I want to go the compare list directly after that in many cases without having to search for a link. Thus, the link has been added to the success message now.

Manual testing scenarios

  1. Go to a product view page
  2. Click "Add to compare"
  3. Check if the success message contains a link to the compare list:
    grafik

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@PieterCappelle
Copy link
Contributor

Very good PR. The same should be done when you add a product to your basket. (add link directly to checkout) :)

@avstudnitz
Copy link
Contributor Author

@PieterCappelle Thanks for the hint, I'll work on it :-)

@osrecio osrecio self-assigned this Mar 5, 2018
@osrecio
Copy link
Member

osrecio commented Mar 5, 2018

Hi @avstudnitz , Thanks for your contribution. I will work to process it. I'll keep you informed.

# Conflicts:
#	app/code/Magento/Catalog/etc/frontend/di.xml
@PieterCappelle
Copy link
Contributor

Hi, when will this be merged?

@okorshenko okorshenko modified the milestones: April 2018, May 2018 May 18, 2018
@osrecio
Copy link
Member

osrecio commented May 25, 2018

Hi, Sorry, I lost this PR in my timeline.

Now is Ready for Delivery. And soon will be merged.

@magento-engcom-team
Copy link
Contributor

Hi @avstudnitz. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.6 release.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants