issue #18931 fixed.

[ghost]

Description (*)

Translation string was missing as the success message is updated in PR #13862

Fixed Issues (if relevant)

1. Product added to shopping cart / comparison list message not translated by default #18931: Product added to shopping cart / comparison list message not translated by default

Manual testing scenarios (*)

1. Change your Locale something other than en_US.
2. Add product to cart or Add product to Compare.
3. The success Message will not be translated.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @ayazwebkul. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[ghost]

@magento-engcom-team give me test instance

[magento-engcom-team]

Hi @ayazwebkul. Thank you for your request. I'm working on Magento instance for you

[magento-engcom-team]

Hi @ayazwebkul, here is your new Magento instance.
Admin access: http://ec2-34-228-235-121.compute-1.amazonaws.com/pr-18938//admin
Login: admin Password: 123123q

[VladimirZaets]

Hi @ayazwebkul. Thanks for collaboration. But, I think that add HTML tag (<a href in the current case) is bad way, we don't do it. First of all because HTML template can changing any time and translation shouldn't be dependet to the view (html template). We should add to translation only plain text.

[arnoudhgz]

@VladimirZaets when I search in the translations there are quite some translations with html tags. If this indeed should be changed according to your review than also the .phtml templates must be changed:

• 3232465
• edd6062

@ayazwebkul The old translation should be removed, when the strings will not be splitted.

[ghost]

@VladimirZaets as per the template, I need to put the same string in the translation file, either the template file is updated so that it doesn't contain the html tags. As I can check the wishlist module, downloadable module too contains such string. If you know the other way round for this, plz provide reference.

[ghost]

@arnoudhgz the previous string is still being used in Addgroup.php file so is not removed from translation file.
https://github.com/magento/magento2/blob/2.3-develop/app/code/Magento/Checkout/Controller/Cart/Addgroup.php#L100

I have removed the old string from catalog page.

[magento-engcom-team]

Hi @VladimirZaets, thank you for the review.
ENGCOM-3345 has been created to process this Pull Request

[magento-engcom-team]

Hi @ayazwebkul. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.