Skip to content

[Up port] Replacing deprecated methods in Magento_Backend module. #17040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[Up port] Replacing deprecated methods in Magento_Backend module. #17040

wants to merge 2 commits into from

Conversation

tiagosampaio
Copy link
Member

@tiagosampaio tiagosampaio commented Jul 23, 2018

Replacing deprecated methods to Magento_Backend.

Description

Replaced methods:

  • addSuccess() by addSuccessMessage();
  • addError() by addErrorMessage();
  • addException() by addExceptionMessage();
  • addNotice() by addNoticeMessage().

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Original PR

#17039

@magento-engcom-team
Copy link
Contributor

Hi @tiagosampaio. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@ihor-sviziev
Copy link
Contributor

Hi @tiagosampaio,
Original PR #17039 was combined with another PR into #17035. It's better to create forward port PR just after #17035 will be merged.

I'm closing this PR as not relevant anymore

@tiagosampaio tiagosampaio deleted the 2.3-develop-006 branch August 7, 2018 13:00
@tiagosampaio tiagosampaio restored the 2.3-develop-006 branch October 18, 2018 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants