Replaced deprecated methods.

[tiagosampaio]

Replaced deprecated methods.

Description

Replaced deprecated methods below:

• addSuccess() by addSuccessMessage()
• addException() by addExceptionMessage()
• addError() by addErrorMessage()

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @tiagosampaio. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[ihor-sviziev]

@magento-engcom-team combine 17036 17039 17048 17058

[magento-engcom-team]

Hi @ihor-sviziev. Thank you for your request. I'm working on combining the pull requests for you

[magento-engcom-team]

@tiagosampaio all pull requests have been successfully combined together:

• merged Replaced deprecated methods for AdvancedPricingImportExport module. #17036: Replaced deprecated methods for AdvancedPricingImportExport module.
• merged Replacing deprecated methods to Magento_Backend. #17039: Replacing deprecated methods to Magento_Backend.
• merged Replacing deprecated methods in Magento_Backup module. #17048: Replacing deprecated methods in Magento_Backup module.
• merged Replacing deprecated methods in Magento_CatalogRule module. #17058: Replacing deprecated methods in Magento_CatalogRule module.

[ihor-sviziev]

Hi,

I merged 5 PRs into single one in order to process them faster.

I see two builds on PRs were failing. Could you review the builds and adjust your code?
Links to failed builds:

• Replacing deprecated methods to Magento_Backend. #17039 - https://travis-ci.org/magento/magento2/builds/407247207
• Replaced deprecated methods. #17035 - https://travis-ci.org/magento/magento2/jobs/407202442

[tiagosampaio]

Hi @ihor-sviziev,

Changes were applied.

Thanks.

[ihor-sviziev]

Hi,
Integration tests are failing. Could you fix your code or adjust tests if needed?

[ihor-sviziev]

@magento-engcom-team give me test instance

[magento-engcom-team]

Hi @ihor-sviziev. Thank you for your request. I'm working on Magento instance for you

[magento-engcom-team]

Hi @ihor-sviziev, here is your new Magento instance.
Admin access: https://pr-17035.engcom.dev.magento.com/admin
Login: admin Password: 123123q

[ihor-sviziev]

I checked following test cases manually:

1. Mass action "refresh" for not existing cache type 👍
2. Mass action "disable" for not existing cache type 👍
3. Mass action "enable" for not existing cache type 👍
   

Looks like on UI everything is good, need just update integration tests assert.
@tiagosampaio could you do that?

---

Edit: Never mind, I'll fix it myself

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-2553 has been created to process this Pull Request

[magento-engcom-team]

Hi @tiagosampaio. Thank you for your contribution.
We will aim to release these changes as part of 2.2.6.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.