[Up Port 2.3] Replacing deprecated methods in Magento_CatalogRule module.

[tiagosampaio]

Replacing deprecated methods in Magento_CatalogRule module.

Description

Replaced methods:

• addSuccess() by addSuccessMessage();
• addError() by addErrorMessage();
• addException() by addExceptionMessage();
• addNotice() by addNoticeMessage().

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

Original PR

#17058

[magento-engcom-team]

Hi @tiagosampaio. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[ihor-sviziev]

Hi @tiagosampaio,
Original PR #17058 was combined with another PR into #17035. It's better to create forward port PR just after #17035 will be merged.

I'm closing this PR as not relevant anymore