Skip to content

[Forwardport] Fix the special price expression #17799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 4, 2018
Merged

[Forwardport] Fix the special price expression #17799

merged 1 commit into from
Sep 4, 2018

Conversation

mage2pratik
Copy link
Contributor

@mage2pratik mage2pratik commented Aug 25, 2018 •
edited by Anomia69
Loading

Description

The priority of "OR" is lower then "AND". That's why we have to add brackets around OR-expresstion.

Fixed Issues (if relevant)

Manual testing scenarios

N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Original PR

#16510

@magento-engcom-team
Copy link
Contributor

Hi @mage2pratik. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@sidolov sidolov changed the title Fix the special price expression [Forwardport] Fix the special price expression Aug 26, 2018
@osrecio osrecio self-assigned this Aug 27, 2018
@osrecio osrecio self-requested a review August 27, 2018 11:07
osrecio
osrecio approved these changes Aug 27, 2018
View reviewed changes
Copy link
Member

@osrecio osrecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @mage2pratik . We will process this PR ASAP

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Aug 27, 2018
@magento-engcom-team
Copy link
Contributor

Hi @osrecio, thank you for the review.
ENGCOM-2881 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit 14ab8ac into magento:2.3-develop Sep 4, 2018
magento-engcom-team pushed a commit that referenced this pull request Sep 4, 2018
ENGCOM-2881: [Forwardport] Fix the special price expression #17799
7b1ad3d
@magento-engcom-team
Copy link
Contributor

Hi @mage2pratik. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

@kanduvisla kanduvisla mentioned this pull request Oct 22, 2018
Merged
4 tasks
magento-engcom-team pushed a commit that referenced this pull request Oct 25, 2018
@kanduvisla
[BUGFIX] GITHUB-18264 Backport of #17799 for the 2.2 branch
36a3c26
magento-engcom-team added a commit that referenced this pull request Oct 25, 2018
@magento-engcom-team
ENGCOM-3261: [BUGFIX] GITHUB-18264 Backport of #17799 for the 2.2 bra…
b8c757c 
…nch #18737

 - Merge Pull Request #18737 from kanduvisla/magento2:GITHUB-18264
 - Merged commits:
   1. 36a3c26
magento-engcom-team pushed a commit that referenced this pull request Oct 25, 2018
ENGCOM-3261: [BUGFIX] GITHUB-18264 Backport of #17799 for the 2.2 bra…
6c7bb10 
…nch #18737
magento-engcom-team added a commit that referenced this pull request Oct 25, 2018
@magento-engcom-team
🔃 [EngCom] Public Pull Requests - 2.2-develop
932c1f6 
Accepted Public Pull Requests:
 - #18737: [BUGFIX] GITHUB-18264 Backport of #17799 for the 2.2 branch (by @kanduvisla)
 - #16940: Resolve incorrect scope code selection when the requested scopeCode is null (by @matthew-muscat)


Fixed GitHub Issues:
 - #18264: M2.2.6 : "Order by price" not working in product listing (reported by @kanduvisla) has been fixed in #18737 by @kanduvisla in 2.2-develop branch
   Related commits:
     1. 36a3c26

 - #16939: Incorrect configuration scope is occasionally returned when attempting to resolve a null scope id (reported by @matthew-muscat) has been fixed in #16940 by @matthew-muscat in 2.2-develop branch
   Related commits:
     1. d79cfa9
     2. a9c4838
     3. 93edb38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osrecio osrecio osrecio approved these changes

Assignees

@osrecio osrecio

Labels
Component: Catalog Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.0
Development

Successfully merging this pull request may close these issues.
5 participants
@mage2pratik @magento-engcom-team @osrecio @chguerra @babyasishhira