Skip to content

[BUGFIX] GITHUB-18264 Backport of #17799 for the 2.2 branch #18737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2018

Conversation

kanduvisla
Copy link
Contributor

Description

This PR is a backport of #17799 for the 2.2 branch. It fixes issue #18264 where the price indexer would generate unwanted results if a special price date is set, but the actual special price is omitted.

Fixed Issues (if relevant)

  1. M2.2.6 : "Order by price" not working in product listing #18264

Manual testing scenarios

  1. Create some products with different prices.
  2. Give them no special price (empty field), but give them a special price from date in the past and/or a special price to date in the future.
  3. Run the price reindexer.
  4. The products that have special price set to (empty field), are now set to the regular price as min_price, resulting in a correct working price sorting.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Oct 22, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @kanduvisla. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@sidolov
Copy link
Contributor

sidolov commented Oct 24, 2018

Hi @kanduvisla , looks like you made some commits with email different than in your GitHub profile, please, add email from commits to your profile and sign CLA!
Thank you!

@kanduvisla
Copy link
Contributor Author

@sidolov : I added the e-mail address to my account on GitHub in re-signed the CLA

@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-3261 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@kanduvisla thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@magento-engcom-team
Copy link
Contributor

Hi @kanduvisla. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants