Skip to content

[Backport] Improve array semicolon and misspelled - #17987

Closed
dmytro-ch wants to merge 1 commit into
magento:2.2-developfrom
dmytro-ch:2.2-develop-PR-port-17820
Closed

dmytro-ch wants to merge 1 commit into
magento:2.2-developfrom
dmytro-ch:2.2-develop-PR-port-17820

Conversation

@dmytro-ch

Copy link
Copy Markdown
Contributor

Original Pull Request

#17820

Description

Just improving code, removing semicolon from array brackets and fix small misspelled.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Sep 8, 2018
@magento-engcom-team

Copy link
Copy Markdown
Contributor

Hi @dmytro-ch. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@sidolov

sidolov commented Sep 8, 2018

Copy link
Copy Markdown
Contributor

Hi @dmytro-ch , due to changes in Magento Code Contributions Guide we can't accept such Pull Requests to 2.2 release line. All code cleanup like typos, spelling mistakes, removing unused code, etc should be delivered to 2.3 release line.
Thank you!

@sidolov sidolov closed this Sep 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Catalog Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Release Line: 2.2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants