Improve array semicolon and misspelled - #17820
Merged
magento-engcom-team merged 1 commit intoSep 4, 2018
Merged
magento-engcom-team merged 1 commit into
magento-engcom-team merged 1 commit into
Conversation
Contributor
|
|
Contributor
|
Hi @williankeller. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
osrecio
self-requested a review
August 28, 2018 10:13
osrecio
approved these changes
Aug 28, 2018
osrecio
left a comment
osrecio
left a comment
Member
There was a problem hiding this comment.
Thanks for your contribution @williankeller . We will process your PR ASAP
Contributor
|
Hi @osrecio, thank you for the review. |
Contributor
|
Hi @williankeller. Thank you for your contribution. |
4 tasks
altdovydas
pushed a commit
to altdovydas/magento2
that referenced
this pull request
Aug 6, 2026
- Merge Pull Request magento#17820 from williankeller/magento2:improve/code/misspelled - Merged commits: 1. 4fcaf1d
altdovydas
pushed a commit
to altdovydas/magento2
that referenced
this pull request
Aug 6, 2026
Accepted Public Pull Requests: - magento#17737: [Forwardport] Replaced deprecated methods. (by @nmalevanec) - magento#17814: Removed unnecessary characters from comments (by @jignesh-baldha) - magento#17799: [Forwardport] Fix the special price expression (by @mage2pratik) - magento#17761: [Forwardport] 16570 enhance performance on large catalog (by @AurelienLavorel) - magento#17720: [Forwardport] ISSUE-17715: Duplicate event in Delete operation transa� (by @p-bystritsky) - magento#17726: [Forwardport] Replace strval() function by using direct type casting to (string) (by @nmalevanec) - magento#17815: [Forwardport] Fill visibility in AdminConfigurableProductCreateTest.xml (by @nmalevanec) - magento#17816: [Forwardport] declare var to fix scope error (by @nmalevanec) - magento#17809: [Forwardport] Adjust page-main container height for sticky footer; fixes magento#15118 (by @nmalevanec) - magento#17820: Improve array semicolon and misspelled (by @williankeller) - magento#17812: [Forwardport] Replaced @escapeNotVerified annotations (by @nmalevanec) - magento#17740: [Forwardport] Added and removed unnecessary translation for label/comment tags (by @nmalevanec) - magento#17392: MSI-1542: Provide MSI support for Shipment Web API endpoint (by @IvanPletnyov) Fixed GitHub Issues: - magento#17715: duplicate event in Delete operation transaction "entity_manager_delete_before" (reported by @zebimax) has been fixed in magento#17720 by @p-bystritsky in 2.3-develop branch Related commits: 1. 05f8e78 - magento#15121: Magento 2.2.4 - Condition Category Chooser Crashes Page if Store has Several Nested Categories (reported by @rjtulloh) has been fixed in magento#17816 by @nmalevanec in 2.3-develop branch Related commits: 1. 3c499db - magento#15118: Responsive Design, Footers do not snap to bottom of screen on mobile devices (reported by @gwharton) has been fixed in magento#17809 by @nmalevanec in 2.3-develop branch Related commits: 1. 5ca1f9c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Just improving code, removing semicolon from array brackets and fix small misspelled.
Contribution checklist