[Forwardport] Update time12h javascript validation rule to be compatible with js minify - #18141
Merged
magento-engcom-team merged 1 commit intoSep 26, 2018
Merged
Conversation
magento-engcom-team
added
Partner: Krish TechnoLabs
partners-contribution
Contributor
|
Hi @mage2pratik. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
VladimirZaets
self-requested a review
September 20, 2018 07:48
VladimirZaets
approved these changes
Sep 20, 2018
Contributor
|
Hi @VladimirZaets, thank you for the review. |
sidolov
changed the title
magento-engcom-team
pushed a commit
that referenced
this pull request
Sep 26, 2018
…le with js minify #18141
Contributor
|
Hi @mage2pratik. Thank you for your contribution. |
altdovydas
pushed a commit
to altdovydas/magento2
that referenced
this pull request
Aug 6, 2026
…le with js minify magento#18141 - Merge Pull Request magento#18141 from mage2pratik/magento2:ref-patch-17688 - Merged commits: 1. cfa4d60
altdovydas
pushed a commit
to altdovydas/magento2
that referenced
this pull request
Aug 6, 2026
Accepted Public Pull Requests: - magento#18207: [Forwardport] Make sure all linked products (related, upsells, crosss� (by @hostep) - magento#18205: [Forwardport] Fix module uninstall shell command and composer removal w/out regression (by @mage2pratik) - magento#18122: Update db schema comments (by @hryvinskyi) - magento#18211: [Forwardport] [CatalogUrlRewrite] Covering the CategoryProcessUrlRewriteMovingObserver by Unit Test (by @eduard13) - magento#18198: [Forwardport] [remove] rich snippet declaration on grouped product (by @AurelienLavorel) - magento#18202: [Forwardport] Current password autocomplete for admin login (by @mage2pratik) - magento#18203: [Forwardport] [2.2] return $this from setters in Analytics/ReportXml/DB/SelectBuilder.php (by @mage2pratik) - magento#18187: Replace sort callbacks to spaceship operator in vendor files (by @mage2pratik) - magento#17685: Replacing deprecated methods from Magento_Backend module. (by @tiagosampaio) - magento#18141: [Forwardport] Update time12h javascript validation rule to be compatible with js minify (by @mage2pratik) - magento-engcom/magento2ce#2159: magento#18009: [Forwardport] Cannot create a numeric value attribute option using the REST API. (by @p-bystritsky) - magento#16351: Magento_Sales integration tests: Fix addresses in order_list fixture (by @evktalo) Fixed GitHub Issues: - magento#13720: Only 2 related products are showing in backend . (reported by @dipind4u) has been fixed in magento#18207 by @hostep in 2.3-develop branch Related commits: 1. 74e1ea9 2. d5b6231 - magento#14050: Import related products issue (reported by @estellehuang) has been fixed in magento#18207 by @hostep in 2.3-develop branch Related commits: 1. 74e1ea9 2. d5b6231 - magento#5797: [2.1.0] module:uninstall can remove code it uses itself (reported by @hostep) has been fixed in magento#18205 by @mage2pratik in 2.3-develop branch Related commits: 1. 8b9fff5 2. fa4289f - magento#17780: Module uninstall does not work with composer (reported by @Thundar) has been fixed in magento#18205 by @mage2pratik in 2.3-develop branch Related commits: 1. 8b9fff5 2. fa4289f - magento#18009: Cannot create a numeric value attribute option using the REST API (reported by @sidm) has been fixed in magento-engcom/magento2ce#2159 by @p-bystritsky in 2.3-develop branch Related commits: 1. 3b9e963
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The space in the validation rule causes this rule to not work correctly when js minify is enabled, as it strips the space out of the validation rule regex.
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist
Original PR
#17652