Skip to content

[Forwardport] [remove] rich snippet declaration on grouped product - #18198

Merged
magento-engcom-team merged 1 commit into
magento:2.3-developfrom
AurelienLavorel:2.3-develop-PR-port-17919
Sep 26, 2018
Merged

magento-engcom-team merged 1 commit into
magento:2.3-developfrom
AurelienLavorel:2.3-develop-PR-port-17919

Conversation

@AurelienLavorel

@AurelienLavorel AurelienLavorel commented Sep 22, 2018 •

Copy link
Copy Markdown
Member

Original Pull Request

#17919

Rich snippet grouped product

Description

Structured data validation on grouped products are failing.

Manual testing scenarios

  1. Use Google validator tool: https://search.google.com/structured-data/testing-tool?hl=en#url=http%3A%2F%2Fmagento2-demo.nexcess.net%2Fset-of-sprite-yoga-straps.html
  2. Check that no errors are fired

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team

Copy link
Copy Markdown
Contributor

Hi @AurelienLavorel. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team

Copy link
Copy Markdown
Contributor

Hi @aleron75, thank you for the review.
ENGCOM-3030 has been created to process this Pull Request

@magento-engcom-team

Copy link
Copy Markdown
Contributor

Hi @AurelienLavorel. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

altdovydas pushed a commit to altdovydas/magento2 that referenced this pull request Aug 6, 2026
…ed product magento#18198

 - Merge Pull Request magento#18198 from AurelienLavorel/magento2:2.3-develop-PR-port-17919
 - Merged commits:
   1. 8542233
altdovydas pushed a commit to altdovydas/magento2 that referenced this pull request Aug 6, 2026
Accepted Public Pull Requests:
 - magento#18207: [Forwardport] Make sure all linked products (related, upsells, crosss� (by @hostep)
 - magento#18205: [Forwardport] Fix module uninstall shell command and composer removal w/out regression (by @mage2pratik)
 - magento#18122: Update db schema comments (by @hryvinskyi)
 - magento#18211: [Forwardport] [CatalogUrlRewrite] Covering the CategoryProcessUrlRewriteMovingObserver by Unit Test (by @eduard13)
 - magento#18198: [Forwardport] [remove] rich snippet declaration on grouped product (by @AurelienLavorel)
 - magento#18202: [Forwardport] Current password autocomplete for admin login (by @mage2pratik)
 - magento#18203: [Forwardport] [2.2] return $this from setters in Analytics/ReportXml/DB/SelectBuilder.php (by @mage2pratik)
 - magento#18187: Replace sort callbacks to spaceship operator in vendor files (by @mage2pratik)
 - magento#17685: Replacing deprecated methods from Magento_Backend module. (by @tiagosampaio)
 - magento#18141: [Forwardport] Update time12h javascript validation rule to be compatible with js minify (by @mage2pratik)
 - magento-engcom/magento2ce#2159: magento#18009: [Forwardport] Cannot create a numeric value attribute option using the REST API. (by @p-bystritsky)
 - magento#16351: Magento_Sales integration tests: Fix addresses in order_list fixture (by @evktalo)


Fixed GitHub Issues:
 - magento#13720: Only 2 related products are showing in backend . (reported by @dipind4u) has been fixed in magento#18207 by @hostep in 2.3-develop branch
   Related commits:
     1. 74e1ea9
     2. d5b6231

 - magento#14050: Import related products issue (reported by @estellehuang) has been fixed in magento#18207 by @hostep in 2.3-develop branch
   Related commits:
     1. 74e1ea9
     2. d5b6231

 - magento#5797: [2.1.0] module:uninstall can remove code it uses itself (reported by @hostep) has been fixed in magento#18205 by @mage2pratik in 2.3-develop branch
   Related commits:
     1. 8b9fff5
     2. fa4289f

 - magento#17780: Module uninstall does not work with composer (reported by @Thundar) has been fixed in magento#18205 by @mage2pratik in 2.3-develop branch
   Related commits:
     1. 8b9fff5
     2. fa4289f

 - magento#18009: Cannot create a numeric value attribute option using the REST API (reported by @sidm) has been fixed in magento-engcom/magento2ce#2159 by @p-bystritsky in 2.3-develop branch
   Related commits:
     1. 3b9e963
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants