requestShippingRates: set quote ID as given by the store manager #18174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not as given by the order itself Because of the issue #12889 this particalur line was added as a "fix", setting the store id for the quote as given by the quote object itself. This lead to the standard shipping method's name shown in the cart view totals and shipping rate listing in the checkout to be shown as given by the store view, where the last product was added. Can be reproduce, if at least two store views, each with a different language and languae specific naming of shipping rates, for one website are given. Add a product in one store view, switch to another language and go the cart view. This change should still solve the problem described in the issue #12889 and don't mess up the labeling of the shipping rates shown in checkout for websites with multilanguage store views.
|
Hi @jhruehl Unfortunately, we cannot accept Pull Requests from branches created in Thank you. |
|
Hi @jhruehl. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requestShippingRates: set quote ID as given by the store manager and not as given by the order itself
Description
Because of the issue #12889 this particalur line was added as a "fix", setting the store id for the quote as given by the quote object itself.
This lead to the standard shipping method's name shown in the cart view totals and shipping rate listing in the checkout to be shown as given by the store view, where the last product was added.
Fixed Issues (if relevant)
This change should still solve the problem described in the issue #12889 and don't mess up the labeling of the shipping rates shown in checkout for websites with multilanguage store views.
Manual testing scenarios
Can be reproduce, if at least two store views, each with a different language and language specific naming of shipping rates, for one website are given. Add a product in one store view, switch to another language and go the checkout/cart view page.
Contribution checklist