[Backport] fix(Webapi Xml Renderer - 18361): removed the not needed ampersand re… #18362

nickshatilo · 2018-10-03T15:03:58Z

Fixes #18361 (ampersand xml serialisation issue)

Description

As described in #18361, the issue is about having the ampersand in any customer text field, and when using the WebApi, it causes an issue of doubling the encoding. I.e &amp;, which is not the case in the XML format, so it should be resolved.

Fixed Issues (if relevant)

Customer last name is encoded twice in the XML interface #18361: Customer last name is encoded twice in the XML interface Customer last name is encoded twice in the XML interface #18361

Manual testing scenarios

Create a customer via Backend with the last name "Foo & Bar Corp"
Create an order (via frontend is fine)
Export the order via XML interfcae

curl -XPOST -H 'Content-Type: application/json' http://hostname/rest/V1/integration/admin/token -d '{ "username": "admin_username", "password": "admin_password" }'
export B=code received above
 curl -X GET --header "Accept: application/xml" --header "Authorization: Bearer $B" "http://hostname/rest/english/V1/orders/1"

The customer_lastname tag should contain Foo & Bar Corp

Contribution checklist

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds on Travis CI are green)

Original PR

#18380

…placement

magento-cicd2 · 2018-10-03T15:04:03Z

All committers have signed the CLA.

rogyar · 2018-10-04T08:28:41Z

Hi @nickshatilo. Thank you for your contribution. According to the contribution guidelines, we can accept changes to the 2.2-develop branch only if they are present in 2.3-develop branch (https://devdocs.magento.com/guides/v2.2/contributor-guide/contributing.html#rules). Please, consider creating the same PR to the 2.3-develop branch first. Thank you.

nickshatilo · 2018-10-04T09:30:59Z

@rogyar Please take a look: #18380

lib/internal/Magento/Framework/Webapi/Rest/Response/Renderer/Xml.php

nickshatilo · 2018-10-11T11:15:57Z

@josefbehr @rogyar avGoncharuk Can you please take a look?

sidolov · 2018-11-06T09:28:20Z

Hi @nickshatilo , I'm closing this PR because original PR (#18380) was closed due to inactivity.
Please, reopen it if you wish to continue.
Thnk you!

sivaschenko · 2018-11-22T13:33:15Z

Reopening as the original pull request is approved

magento-engcom-team · 2019-01-22T14:35:52Z

Hi @sivaschenko, thank you for the review.
ENGCOM-3929 has been created to process this Pull Request

ghost · 2019-01-26T18:01:43Z

Hi @nickshatilo, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

… not needed ampersand re… #18362

magento-engcom-team · 2019-01-26T18:02:05Z

Hi @nickshatilo. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

* Escaped output of html attributes * MAGETWO-97466: Refreshing checkout page deletes shipping address on guest checkout * MAGETWO-96711: One page Checkout resets Customer data if Product Qty was changed * MAGETWO-72879: Update product from mini shopping cart doesn't reflect in the shopping cart * meassage icon alignment issue resolved * ENGCOM-3851: Static test fix. * ENGCOM-3893: Static test fix. * MAGETWO-96711: One page Checkout resets Customer data if Product Qty was changed * MAGETWO-97826: Skipped Randomly failing MFTF test AdminCheckingCreditMemoTotalsTest * MAGETWO-97825: Skipped Randomly failing test AdminCreateCreditMemoWhenCartRuleDeletedTest * Fixed-19800: Contact us : design improvement. * Fixed 19800 Contact us : design improvement * Fixed 19800 Contact us : design improvement * Fixed 19800 Contact us : design improvement * Fixed 19800 Contact us : design improvement * Fixed 19800 Contact us : design improvement * ENGCOM-3763: Static test fix. * Fixed-19791: Logo vertical misalignment. * Fixed-Checkbox-Alignement: Checkbox alignment issue. * MAGETWO-72879: Update product from mini shopping cart doesn't reflect in the shopping cart * MAGETWO-96711: One page Checkout resets Customer data if Product Qty was changed * MAGETWO-94348: The cart rule cannot affect the Bundle product with Fixed Price * magento#18362: Fixed static tests * Added constants to unit codes to make it easier to reuse it if necessary. * ENGCOM-3774: Static test fix. * MAGETWO-96815: There is no option to remove the Store Credit from the payment page of checkout * Fix negative credit memo bug caused by credit memo discount total calculator * ENGCOM-3720: Static test fix. * Added required error message. If any JSON error occurs user will be be shown error message if the app mode is not in Production. * Fixed Unused Local variable * Fixed unused local variable * Removed use of Class ObjectManager in Construct * Updated to show error message to all Env. * Update lib/internal/Magento/Framework/Serialize/Serializer/Json.php Co-Authored-By: vinogcs <[email protected]> * ENGCOM-3782: Static test fix. * Add useful debug info for which website has not been found * Add with code/with id text * MAGETWO-73598: CLONE - Quans: Orders API without key/value on ADDITIONAL_INFORMATION (only values) * MAGETWO-96815: There is no option to remove the Store Credit from the payment page of checkout * Issue fixed magento#19985 Send email confirmation popup close button area overlapping to content Issue fixed magento#19985 Send email confirmation popup close button area overlapping to content * Issue fixed magento#19985 Send email confirmation popup close button area overlapping Issue fixed magento#19985 Send email confirmation popup close button area overlapping * Order API resources updated. * 'wishlist-page-edit-remove-item-misalign' :: On wish list page edit, remove item misalign in 640 X 767 resolution * Order-view-invoices :: Order view invoices template not display proper on ipad * Updated CancelOrderItemObserver.php Fixed Issue magento#20121 Cancel order increases stock although "Set Items' Status to be In Stock When Order is Cancelled" is set to No * ENGCOM-3845: Static test fix. * MAGETWO-74604: Event clean_cache_by_tags didn't clean all tags pointed in getIdentity * MAGETWO-73598: CLONE - Quans: Orders API without key/value on ADDITIONAL_INFORMATION (only values) * MAGETWO-97899: [FT] [MFTF] AdminAvailabilityCreditMemoWithNoPaymentTest fails because of bad design * MAGETWO-94157: Issue with products with customizable options * MAGETWO-94348: The cart rule cannot affect the Bundle product with Fixed Price * MAGETWO-93832: Automate with MFTF Copy Single Update to Another Update * MAGETWO-73598: CLONE - Quans: Orders API without key/value on ADDITIONAL_INFORMATION (only values) * Static test fix. * MAGETWO-95276: Varnish "Connection reset by peer" error when large catalog is reindexed on schedule * MAGETWO-95176: Detaching category from product causes massive product url regeneration * MAGETWO-94348: The cart rule cannot affect the Bundle product with Fixed Price * MAGETWO-73625: Products change in one category will cause cache miss for other categories (Only reproducible by unassigning products from backend category page) * admin-order-info-issue2.2 * MAGETWO-94348: The cart rule cannot affect the Bundle product with Fixed Price * MAGETWO-94348: The cart rule cannot affect the Bundle product with Fixed Price * Fix static test. * MAGETWO-95176: Detaching category from product causes massive product url regeneration * magento#20376 Fix issue with file uploading if an upload field is disabled * magento#20461 Add translate component * (Fixes issue magento#18027) Round the total amount to 4 decimal places, to avoid floating point overflows * round the total amount only if it is float * round base total amount * cast formatted number to float * thousand separator removed from number format * use round instead of number_format to round the total amount * unnecessary comments removed * ENGCOM-3464: Static tests fixed. * fixed Negative order amount in dashboard - magento#18754 * Fix static test. * Update styles-old.less * update-button-issue-while-updating-billing-and-shipping-address * MAGETWO-95752: Unable to create Configurations for Configurable Products * issue fixed magento#20563 Go to shipping information, Update qty & Addresses and Enter a new address button Not aligned from left and right in 767px screen size issue fixed magento#20563 Go to shipping information, Update qty & Addresses and Enter a new address button Not aligned from left and right in 767px screen size * recent-order-product-title-misaligned * Fix static tests. * Fix static tests. * MAGETWO-94348: The cart rule cannot affect the Bundle product with Fixed Price * MAGETWO-95752: Unable to create Configurations for Configurable Products * MAGETWO-95752: Unable to create Configurations for Configurable Products * MAGETWO-95752: Unable to create Configurations for Configurable Products * MAGETWO-94114: Cannot refresh Captcha image in production mode * MQE-1420: Bump MFTF version in Magento - MFTF version bump + allure-codeception dependency update. * MQE-1420: Bump MFTF version in Magento - changing argument from its own attribute to part of the command * Fixed issue of Lifetime update syntax error * Fix static test.

fix(Webapi Xml Renderer - 18361): removed the not needed ampersand re…

ecd9dc4

…placement

magento-engcom-team added Component: Framework/Webapi USE ONLY for FRAMEWORK RELATED BUG! E.g If bug related to Catalog WEB API use just Catalog Release Line: 2.2 labels Oct 3, 2018

rogyar self-assigned this Oct 4, 2018

rogyar added the Progress: on hold label Oct 4, 2018

nickshatilo changed the base branch from 2.2-develop to 2.3-develop October 4, 2018 08:32

nickshatilo changed the base branch from 2.3-develop to 2.2-develop October 4, 2018 08:32

nickshatilo mentioned this pull request Oct 4, 2018

fix(Webapi Xml Renderer - 18361): removed the not needed ampersand re… #18380

Merged

4 tasks

sidolov changed the title ~~fix(Webapi Xml Renderer - 18361): removed the not needed ampersand re…~~ [Backport] fix(Webapi Xml Renderer - 18361): removed the not needed ampersand re… Oct 4, 2018

amenk suggested changes Oct 5, 2018

View reviewed changes

lib/internal/Magento/Framework/Webapi/Rest/Response/Renderer/Xml.php Outdated Show resolved Hide resolved

josefbehr self-assigned this Oct 6, 2018

josefbehr added Progress: needs update and removed Progress: on hold labels Oct 8, 2018

fix(Webapi Xml Renderer - 18361): added unit test for the issue

0f75306

amenk approved these changes Oct 9, 2018

View reviewed changes

sidolov added the Progress: on hold label Oct 29, 2018

sidolov closed this Nov 6, 2018

sivaschenko reopened this Nov 22, 2018

sivaschenko self-assigned this Nov 22, 2018

sivaschenko removed the Progress: needs update label Nov 22, 2018

#18362: Fixed static tests

ed497dc

sivaschenko approved these changes Jan 22, 2019

View reviewed changes

sivaschenko removed the Progress: on hold label Jan 22, 2019

magento-engcom-team added this to the Release: 2.2.8 milestone Jan 22, 2019

magento-engcom-team added the Progress: accept label Jan 25, 2019

magento-engcom-team mentioned this pull request Jan 26, 2019

Customer last name is encoded twice in the XML interface #18361

Closed

magento-engcom-team merged commit ed497dc into magento:2.2-develop Jan 26, 2019

magento-engcom-team pushed a commit that referenced this pull request Jan 26, 2019

ENGCOM-3929: [Backport] fix(Webapi Xml Renderer - 18361): removed the…

31af010

… not needed ampersand re… #18362

magento-engcom-team added the Port label Jan 26, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Backport] fix(Webapi Xml Renderer - 18361): removed the not needed ampersand re… #18362

[Backport] fix(Webapi Xml Renderer - 18361): removed the not needed ampersand re… #18362

Uh oh!

nickshatilo commented Oct 3, 2018 •

edited by sidolov

Loading

Uh oh!

magento-cicd2 commented Oct 3, 2018 •

edited

Loading

Uh oh!

rogyar commented Oct 4, 2018

Uh oh!

nickshatilo commented Oct 4, 2018

Uh oh!

Uh oh!

nickshatilo commented Oct 11, 2018 •

edited

Loading

Uh oh!

sidolov commented Nov 6, 2018

Uh oh!

sivaschenko commented Nov 22, 2018

Uh oh!

magento-engcom-team commented Jan 22, 2019

Uh oh!

ghost commented Jan 26, 2019

Uh oh!

magento-engcom-team commented Jan 26, 2019

Uh oh!

Uh oh!

[Backport] fix(Webapi Xml Renderer - 18361): removed the not needed ampersand re… #18362

[Backport] fix(Webapi Xml Renderer - 18361): removed the not needed ampersand re… #18362

Uh oh!

Conversation

nickshatilo commented Oct 3, 2018 • edited by sidolov Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Fixed Issues (if relevant)

Manual testing scenarios

Contribution checklist

Original PR

Uh oh!

magento-cicd2 commented Oct 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rogyar commented Oct 4, 2018

Uh oh!

nickshatilo commented Oct 4, 2018

Uh oh!

Uh oh!

nickshatilo commented Oct 11, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sidolov commented Nov 6, 2018

Uh oh!

sivaschenko commented Nov 22, 2018

Uh oh!

magento-engcom-team commented Jan 22, 2019

Uh oh!

ghost commented Jan 26, 2019

Uh oh!

magento-engcom-team commented Jan 26, 2019

Uh oh!

Uh oh!

nickshatilo commented Oct 3, 2018 •

edited by sidolov

Loading

magento-cicd2 commented Oct 3, 2018 •

edited

Loading

nickshatilo commented Oct 11, 2018 •

edited

Loading