fix(Webapi Xml Renderer - 18361): removed the not needed ampersand re…

[nickshatilo]

Fixes #18361 (ampersand xml serialisation issue)

Description

As described in #18361, the issue is about having the ampersand in any customer text field, and when using the WebApi, it causes an issue of doubling the encoding. I.e &, which is not the case in the XML format, so it should be resolved.

Fixed Issues (if relevant)

1. Customer last name is encoded twice in the XML interface #18361: Customer last name is encoded twice in the XML interface Customer last name is encoded twice in the XML interface #18361

Manual testing scenarios

1. Create a customer via Backend with the last name "Foo & Bar Corp"
2. Create an order (via frontend is fine)
3. Export the order via XML interfcae

curl -XPOST -H 'Content-Type: application/json' http://hostname/rest/V1/integration/admin/token -d '{ "username": "admin_username", "password": "admin_password" }'
export B=code received above
 curl -X GET --header "Accept: application/xml" --header "Authorization: Bearer $B" "http://hostname/rest/english/V1/orders/1"

The customer_lastname tag should contain Foo & Bar Corp

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

It is a copy of PR #18362

[josefbehr]

@nickshatilo Thank you for your contribution. Please add class annotations so that the tests pass, and consider applying the change requested at the 2.2-PR (#18362 (comment)).

[nickshatilo]

@josefbehr Fixed. :)

[josefbehr]

@nickshatilo Thanks. Could you also please fix the static tests?

[sidolov]

Hi @nickshatilo , any updates in this? Thank you!

[sidolov]

Hi @nickshatilo , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

[amenk]

phew .. it's unlucky that is closed because of problematic static tests ...

[amenk]

@nickshatilo will work tomorrow on this

[magento-engcom-team]

Hi @sivaschenko, thank you for the review.
ENGCOM-3535 has been created to process this Pull Request

[magento-engcom-team]

@nickshatilo thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

[amenk]

cool, please merge :)

[magento-engcom-team]

Hi @nickshatilo. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.