Fix: Exception Error in Catalog Price Rule while Backend language is not English

[Mardl]

Fix for: #12399 cause it's not fixed in 2.3-develop

Description

I took the fix from #12399 (comment) cause it's almost identical code like
app/code/Magento/SalesRule/Controller/Adminhtml/Promo/Quote/Save.php:30

Fixed Issues (if relevant)

1. Exception Error in Catalog Price Rule while Backend language is not English #12399 : Exception Error in Catalog Price Rule while Backend language is not English

Manual testing scenarios

https://youtu.be/xBMxMfKHmuc

1. Go to: System -> All User -> [Choose your user]
2. Change Interface Locale to Italien or French or Portuguese
3. Relogin with this user
4. Go to: Marketing -> catalog price rule
5. Edit a record already created (or create a new)
6. Set date From and/or To for example 20 Mai 2019 (Portuguese like "20/02/2019")
7. Click on "Save and Apply"

PHP DateTime can not work with that format. Same problem in Promo/Quote/Save was fixed 2014 and 2016. Maybe forget to fix in Promo/Catalog/Save too.

Contribution checklist

• [X ] Pull request has a meaningful description of its purpose
• [X ] All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-cicd2]

All committers have signed the CLA.

[josefbehr]

@Mardl Thank you for your contribution ;) Please fix the failing tests:

FILE: ...2/app/code/Magento/CatalogRule/Controller/Adminhtml/Promo/Catalog/Save.php

FOUND 3 ERRORS AFFECTING 3 LINES

16 | ERROR | [x] Missing short description
42 | ERROR | [x] Missing short description
43 | ERROR | [x] There must be exactly one blank line before tags

Additionally, would it be possible to provide test cases for this, so future changes don't cause a regression?

[magento-engcom-team]

Hi @josefbehr, thank you for the review.
ENGCOM-3131 has been created to process this Pull Request

[magento-engcom-team]

Hi @Mardl. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.