[Backport] Fix for #12399: Exception Error in Catalog Price Rule while Backend language is not English#19074
Conversation
|
Hi @Mardl. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
|
Hi @josefbehr, thank you for the review. |
…ice Rule while Backend language is not English #19074
|
Hi @Mardl. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
|
@magento-engcom-team this was just a backport from #18419 . It is already in 2.3-develop and will be in 2.3.1 release |
Original Pull Request
#18419
Fix for: #12399 cause it's not fixed in 2.2-develop
Description
I took the fix from #12399 (comment) cause it's almost identical code like
app/code/Magento/SalesRule/Controller/Adminhtml/Promo/Quote/Save.php:30
Fixed Issues (if relevant)
Manual testing scenarios
https://youtu.be/xBMxMfKHmuc
PHP DateTime can not work with that format. Same problem in Promo/Quote/Save was fixed 2014 and 2016. Maybe forget to fix in Promo/Catalog/Save too.
Contribution checklist