Skip to content

Fix typo on product details causing Validation error. #18522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 16, 2018

Conversation

BezV8
Copy link
Contributor

@BezV8 BezV8 commented Oct 11, 2018

Description

Fixes a typo on the aria-labeleledby attribute on the product page causing a W3C Validation error.

Fixed Issues (if relevant)

Manual testing scenarios

  1. Navigate to the view page of any product.
  2. Check the code on the W3C html validator.
  3. Currently product pages return a "Attribute aria-labeledby not allowed on element div at this point." error as there is a typo in app/code/Magento/Catalog/view/frontend/templates/product/view/details.phtml

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

BezV8 and others added 2 commits October 11, 2018 08:57
Fixes a typo on the aria-labeleledby attribute on the product page causing a W3C Validation error.
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Oct 11, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

@BezV8 thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@nuzil nuzil self-requested a review October 11, 2018 12:12
Copy link
Contributor

@nuzil nuzil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution

@magento-engcom-team
Copy link
Contributor

Hi @nuzil, thank you for the review.
ENGCOM-3162 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @BezV8. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants