Skip to content

[Backport] Fix product details causing Validation error #18656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

gelanivishal
Copy link
Contributor

Original Pull Request

#18522

Description

Fixes a typo on the aria-labeleledby attribute on the product page causing a W3C Validation error.

Fixed Issues (if relevant)

Manual testing scenarios

  1. Navigate to the view page of any product.
  2. Check the code on the W3C html validator.
  3. Currently product pages return a "Attribute aria-labeledby not allowed on element div at this point." error as there is a typo in app/code/Magento/Catalog/view/frontend/templates/product/view/details.phtml

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

BezV8 added 2 commits October 16, 2018 23:54
Fixes a typo on the aria-labeleledby attribute on the product page causing a W3C Validation error.
@magento-engcom-team
Copy link
Contributor

Hi @gelanivishal. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

Copy link
Member

@rodrigowebjump rodrigowebjump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gelanivishal
Thanks for your contribution

@rodrigowebjump rodrigowebjump self-assigned this Oct 17, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.8 milestone Oct 17, 2018
@magento-engcom-team
Copy link
Contributor

Hi @rodrigowebjump, thank you for the review.
ENGCOM-3204 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @gelanivishal. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants