-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Remove wrong test expectation #18606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[TSG-CSL3] Backporting 2.2 (pr3)
The bug caused issues during the export of analytics data from advanced reporting. The scandir has parameter were the sort can be placed, but using UNSORTED gives you unwanted lists of files/dirs. Therefor deleting the first 2 via array_shift, is not a proper way of dealing with this Signed-off-by: Harold Claus <[email protected]>
…re states during setup upgrade #16885
…eted from media gallery browser
Accepted Public Pull Requests: - #18215: fix wysiwyg editor not decoding base64 filenames special chars (by @adammada) - #18280: [Backport] Change sort order for customer group options (by @dmytro-ch) - #18086: Cast products "getStoreId()" to int, closes #18079 (by @sreichel) - #16885: [Fix] Do not modify current list of countries with require states during setup upgrade (by @jalogut) Fixed GitHub Issues: - #18138: WYSIWYG editor fails to parse directives of files with special characters in URL (so random files) (reported by @adammada) has been fixed in #18215 by @adammada in 2.2-develop branch Related commits: 1. 4e62fe3 2. bf2efff - #18101: Wrong sort order for customer groups in customer grid filter (reported by @sreichel) has been fixed in #18280 by @dmytro-ch in 2.2-develop branch Related commits: 1. 484bbba 2. dd9b294 - #18079: Inconsistent return type for getStoreId() (reported by @sreichel) has been fixed in #18086 by @sreichel in 2.2-develop branch Related commits: 1. 9d8b04a
…WO-94384' into pr_helix_2.2
…asses. Implemented validation of exception message in unit test
Accepted Public Pull Requests: - #18196: Fix for custom product attribute changing 'backend_type' when 'is_user_defined = 1' and get updated/saved in Admin Backend (by @bartoszkubicki) - #17968: Fix Customer custom attributes lost after save (by @Thundar) Fixed GitHub Issues: - #9219: Custom Product Attribute changes 'backend_type' when 'is_user_defined = 1' and get updated/saved in Admin Backend (reported by @mhauri) has been fixed in #18196 by @bartoszkubicki in 2.2-develop branch Related commits: 1. f6a9459 - #12479: Saving Customer Model directly causes loss of data (reported by @Danielc3) has been fixed in #17968 by @Thundar in 2.2-develop branch Related commits: 1. 7965c9b 2. 44fe03f 3. 6a098a7
…n if attribute is required #18564
…ng validate scheme #18554
…n undefined" issue #18495
Accepted Public Pull Requests: - #18559: [Backport] Covering the AssignOrderToCustomerObserver by Unit Test (by @gelanivishal) - #18564: [Backport] Empty option Label should always be blank even if attribute is required (by @gelanivishal) - #18556: [Backport] Fixed typo from filed to field (by @gelanivishal) - #18554: [Backport] throw exception InvalidArgumentException during validate scheme (by @gelanivishal) - #18552: [Backport] Added validation on maximum quantity allowed in shopping cart (by @gelanivishal) - #18495: [Backport] Checkout - Fix "Cannot read property 'code' on undefined" issue (by @ihor-sviziev) Fixed GitHub Issues: - #14555: Communication's component validator does not propagate exceptions, obscuring the cause of the error (reported by @nikita2206) has been fixed in #18554 by @gelanivishal in 2.2-develop branch Related commits: 1. 3109909 2. 9afdfee 3. 791609c 4. beeecaf 5. 7e38326 6. a20968d 7. 2f2cafe 8. 72b31c9 9. a7cdae0 10. 74c6bfd - #18477: Set maximum Qty Allowed in Shopping Cart is 0 still allow adding to cart (reported by @duongdiep212) has been fixed in #18552 by @gelanivishal in 2.2-develop branch Related commits: 1. db4ac89 - #18164: Checkout - Cannot read property 'code' of undefined (reported by @bruno-serfe) has been fixed in #18495 by @ihor-sviziev in 2.2-develop branch Related commits: 1. e7f70ab 2. 25e3cfe
2.2 develop
Mariana seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
Hi @markoshust. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
Description (*)
Removing wrong test expectation which fails unit tests
Fixed Issues (if relevant)
Manual testing scenarios (*)
bin/magento dev:tests:run unit
, which fails with:Contribution checklist (*)