-
Notifications
You must be signed in to change notification settings - Fork 9.4k
[Forwardport] fixed Quote Item Prices are NULL in cart related events. #18685 #18806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @ashutoshwebkul. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
#squashtoberfest |
Hi @VladimirZaets, thank you for the review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ashutoshwebkul. Why your port contains more code changes than original Pull Request? What the reason for that?
Hi @ashutoshwebkul, I am closing this PR now due to inactivity. |
Hi @ashutoshwebkul, thank you for your contribution! |
Description (*)
before these two observers checkout_cart_product_add_after, checkout_cart_product_update_after cart item is not saved into the database the object is only created and in the object price was not set but custom price was set so there was no issue of custom price, we could have added the price in the item from two files:
app/code/Magento/Quote/Model/Quote/Item/Processor.php and
app/code/Magento/Quote/Model/Quote.php
I have added the price in this file app/code/Magento/Quote/Model/Quote/Item/Processor.php
Fixed Issues (if relevant)
Manual testing scenarios (*)
Contribution checklist (*)
Backport for: #18808