-
Notifications
You must be signed in to change notification settings - Fork 9.4k
fixed Quote Item Prices are NULL in cart related events. #18685 #18808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @ashutoshwebkul. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
#squashtoberfest |
Hi @VladimirZaets, thank you for the review. |
@magento-engcom-team, why there is no reward update on the pull request, is there anything else need to be done, I am new to contribution so please guide me and is this pull request eligible for #squashtoberfest event |
@magento-engcom-team can I know the reason why review failed, I went through the details at codacy but there is no proper description, please explain so i can fix this |
Hi @ashutoshwebkul. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
Description (*)
before these two observers checkout_cart_product_add_after, checkout_cart_product_update_after cart item is not saved into the database the object is only created and in the object price was not set but custom price was set so there was no issue of custom price, we could have added the price in the item from two files:
app/code/Magento/Quote/Model/Quote/Item/Processor.php and
app/code/Magento/Quote/Model/Quote.php
I have added the price in this file app/code/Magento/Quote/Model/Quote/Item/Processor.php
Fixed Issues (if relevant)
Manual testing scenarios (*)
Contribution checklist (*)